Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ CONFLICT! Lineage pull request for: skeleton #96

Merged
merged 33 commits into from
Aug 15, 2024
Merged

Conversation

cisagovbot
Copy link

@cisagovbot cisagovbot commented Aug 12, 2024

Lineage Pull Request: CONFLICT

Achtung!!!

Lineage has created this pull request to incorporate new changes found in an
upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-packer.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with
your project.

The lineage/skeleton branch has one or more unresolved merge conflicts
that you must resolve before merging this pull request!

How to resolve the conflicts

  1. Take ownership of this pull request by removing any other assignees.

  2. Clone the repository locally, and reapply the merge:

    git clone git@github.com:cisagov/teamserver-packer.git teamserver-packer
    cd teamserver-packer
    git remote add skeleton https://github.com/cisagov/skeleton-packer.git
    git remote set-url --push skeleton no_push
    git switch develop
    git switch --create lineage/skeleton --track origin/develop
    git pull skeleton HEAD
    git status
  3. Review the changes displayed by the status command. Fix any conflicts and
    possibly incorrect auto-merges.

  4. After resolving each of the conflicts, add your changes to the
    branch, commit, and push your changes:

    git add .github/workflows/build.yml .github/workflows/prerelease.yml .github/workflows/release.yml src/packer.pkr.hcl src/version.txt terraform-post-packer/main.tf 
    git commit
    git push --force --set-upstream origin lineage/skeleton

    Note that you may append to the default merge commit message
    that git creates for you, but please do not delete the existing
    content
    . It provides useful information about the merge that is
    being performed.

  5. Wait for all the automated tests to pass.

  6. Confirm each item in the "Pre-approval checklist" below.

  7. Remove any of the checklist items that do not apply.

  8. Ensure every remaining checkbox has been checked.

  9. Mark this draft pull request "Ready for review".

✅ Pre-approval checklist

  • ✌️ The conflicts in this pull request have been resolved.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • All new and existing tests pass.
  • Build and test a staging AMI with these changes.

✅ Pre-merge checklist

  • Bump major, minor, patch, or pre-release version as appropriate via the bump_version.sh script if this repository is versioned and the changes in this PR warrant a version bump.
  • Finalize version.
  • Adjust this repo's list of GitHub Actions checks now that the AMI is being built via a matrix.

✅ Post-merge checklist

  • Create a release.

Note

You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

jsf9k and others added 27 commits May 21, 2024 15:03
We can do this because new versions of ansible-core (2.16.7 and
2.17.0) have been released that do not suffer from the bug discussed
in ansible/ansible#82702.  This bug broke any symlinked files in vars,
tasks, etc. for any Ansible role installed via ansible-galaxy.

All versions later than ansible-core 2.16.7 and 2.17.0 should function
as expected.
New versions of ansible-core (2.16.7 and 2.17.0) have been released
that do not suffer from the bug discussed in ansible/ansible#82702.
This bug broke any symlinked files in vars, tasks, etc. for any
Ansible role installed via ansible-galaxy.

All versions later than ansible-core 2.16.7 and 2.17.0 should function
as expected.

Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
The line is not only unnecessary, it was commented out to boot!
…lint

On its own ansible-lint does not pull in ansible, only ansible-core.
Therefore, if an Ansible module lives in ansible instead of
ansible-core, the linter will complain that the module is unknown.  In
these cases it is necessary to add the ansible package itself as an
additional dependency, with the same pinning as is done in
requirements-test.txt of cisagov/skeleton-ansible-role.
This is done automatically with the `pre-commit autoupdate` command.
The pre-commit/mirrors-prettier was manually held back because the
latest tags are for alpha releases of the next major version.
Use the latest v3 release available from NPM.
The pin now agrees with what is in cisagov/skeleton-ansible-role.

Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Update version pin on `ansible-core` Python package
Lineage pull request for: skeleton
This is more flexible than filtering the architecture just based on
the name, particularly since the name filter does not support
full-fledged regexes.
This should make the search more efficient.
This will allow us to build both x86-64 and ARM64 versions of our AMI.
In order that the builds should complete as soon as possible, the
different architectures are built in parallel.
We want to be able to offer both wherever possible.
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
…sions

Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Also reference issue cisagov/skeleton-packer#369 to consider removing
the moved blocks when they are no longer necessary.
Co-authored-by: David Redmin <david.redmin@gwe.cisa.dhs.gov>
…s-as-separate-filter

Build both ARM64 and x86-64 AMIs
@jsf9k jsf9k added dependencies Pull requests that update a dependency file terraform Pull requests that update Terraform code github-actions Pull requests that update GitHub Actions code packer Pull requests that update Packer code labels Aug 14, 2024
@jsf9k jsf9k added version bump This issue or pull request increments the version number terraform Pull requests that update Terraform code packer Pull requests that update Packer code and removed version bump This issue or pull request increments the version number terraform Pull requests that update Terraform code packer Pull requests that update Packer code labels Aug 14, 2024
@jsf9k jsf9k marked this pull request as ready for review August 15, 2024 16:15
@jsf9k jsf9k requested a review from a team August 15, 2024 16:16
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one tiny comment suggestion.

terraform-post-packer/outputs.tf Show resolved Hide resolved
@jsf9k jsf9k enabled auto-merge August 15, 2024 17:18
@jsf9k jsf9k merged commit f6ba6d5 into develop Aug 15, 2024
8 checks passed
@jsf9k jsf9k deleted the lineage/skeleton branch August 15, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github-actions Pull requests that update GitHub Actions code packer Pull requests that update Packer code terraform Pull requests that update Terraform code upstream update This issue or pull request pulls in upstream updates version bump This issue or pull request increments the version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants