-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ CONFLICT! Lineage pull request for: skeleton #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can do this because new versions of ansible-core (2.16.7 and 2.17.0) have been released that do not suffer from the bug discussed in ansible/ansible#82702. This bug broke any symlinked files in vars, tasks, etc. for any Ansible role installed via ansible-galaxy. All versions later than ansible-core 2.16.7 and 2.17.0 should function as expected.
New versions of ansible-core (2.16.7 and 2.17.0) have been released that do not suffer from the bug discussed in ansible/ansible#82702. This bug broke any symlinked files in vars, tasks, etc. for any Ansible role installed via ansible-galaxy. All versions later than ansible-core 2.16.7 and 2.17.0 should function as expected. Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
The line is not only unnecessary, it was commented out to boot!
…lint On its own ansible-lint does not pull in ansible, only ansible-core. Therefore, if an Ansible module lives in ansible instead of ansible-core, the linter will complain that the module is unknown. In these cases it is necessary to add the ansible package itself as an additional dependency, with the same pinning as is done in requirements-test.txt of cisagov/skeleton-ansible-role.
This is done automatically with the `pre-commit autoupdate` command. The pre-commit/mirrors-prettier was manually held back because the latest tags are for alpha releases of the next major version.
Use the latest v3 release available from NPM.
The pin now agrees with what is in cisagov/skeleton-ansible-role. Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Update `pre-commit` hooks
…ible-lint Pin packages for `ansible-lint`
Update version pin on `ansible-core` Python package
Lineage pull request for: skeleton
This is more flexible than filtering the architecture just based on the name, particularly since the name filter does not support full-fledged regexes.
This should make the search more efficient.
This will allow us to build both x86-64 and ARM64 versions of our AMI.
In order that the builds should complete as soon as possible, the different architectures are built in parallel.
We want to be able to offer both wherever possible.
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
…sions Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Also reference issue cisagov/skeleton-packer#369 to consider removing the moved blocks when they are no longer necessary.
Co-authored-by: David Redmin <david.redmin@gwe.cisa.dhs.gov>
…s-as-separate-filter Build both ARM64 and x86-64 AMIs
jsf9k
added
dependencies
Pull requests that update a dependency file
terraform
Pull requests that update Terraform code
github-actions
Pull requests that update GitHub Actions code
packer
Pull requests that update Packer code
labels
Aug 14, 2024
Cobalt Strike foes not currently support ARM64.
jsf9k
force-pushed
the
lineage/skeleton
branch
from
August 14, 2024 16:36
09bab3a
to
e4d78d2
Compare
jsf9k
added
version bump
This issue or pull request increments the version number
terraform
Pull requests that update Terraform code
packer
Pull requests that update Packer code
and removed
version bump
This issue or pull request increments the version number
terraform
Pull requests that update Terraform code
packer
Pull requests that update Packer code
labels
Aug 14, 2024
jsf9k
requested review from
dav3r,
felddy,
jasonodoom,
jsf9k and
mcdonnnj
as code owners
August 15, 2024 16:15
dv4harr10
approved these changes
Aug 15, 2024
dav3r
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one tiny comment suggestion.
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
jsf9k
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
github-actions
Pull requests that update GitHub Actions code
packer
Pull requests that update Packer code
terraform
Pull requests that update Terraform code
upstream update
This issue or pull request pulls in upstream updates
version bump
This issue or pull request increments the version number
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lineage Pull Request: CONFLICT
Lineage has created this pull request to incorporate new changes found in an
upstream repository:
Upstream repository:
https://github.com/cisagov/skeleton-packer.git
Remote branch:
HEAD
Check the changes in this pull request to ensure they won't cause issues with
your project.
The
lineage/skeleton
branch has one or more unresolved merge conflictsthat you must resolve before merging this pull request!
How to resolve the conflicts
Take ownership of this pull request by removing any other assignees.
Clone the repository locally, and reapply the merge:
Review the changes displayed by the
status
command. Fix any conflicts andpossibly incorrect auto-merges.
After resolving each of the conflicts,
add
your changes to thebranch,
commit
, andpush
your changes:Note that you may append to the default merge commit message
that git creates for you, but please do not delete the existing
content. It provides useful information about the merge that is
being performed.
Wait for all the automated tests to pass.
Confirm each item in the "Pre-approval checklist" below.
Remove any of the checklist items that do not apply.
Ensure every remaining checkbox has been checked.
Mark this draft pull request "Ready for review".
✅ Pre-approval checklist
✅ Pre-merge checklist
bump_version.sh
script if this repository is versioned and the changes in this PR warrant a version bump.✅ Post-merge checklist
Note
You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.
For more information:
🛠 Lineage configurations for this project are stored in
.github/lineage.yml
📚 Read more about Lineage