Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling tabs focused tab display issue #987

Closed
frattaro opened this issue Oct 28, 2021 · 5 comments · Fixed by #992
Closed

Scrolling tabs focused tab display issue #987

frattaro opened this issue Oct 28, 2021 · 5 comments · Fixed by #992
Labels
good first issue Good for newcomers

Comments

@frattaro
Copy link
Contributor

Describe the bug

When a tab in scrolling tabs is focused, the top border isn't appearing:
image

To Reproduce
Steps to reproduce the behavior:

Go here: https://atomic-react.security.cisco.com/components/tab#scrolling
click a tab, see missing top border

Expected behavior

The top border should be visible

Additional context

.a-tab-group__tab-content needs 1px top padding. After the change is made, the github action workflow Update Snapshots needs run on the published branch, and that should update the visual regression test assets

@frattaro frattaro added the good first issue Good for newcomers label Oct 28, 2021
@MizuhoOkimoto
Copy link
Contributor

Hi, may I work on it? I appreciate it if you assign it to me.

@frattaro
Copy link
Contributor Author

@MizuhoOkimoto Everything is up for grabs, feel free to assign yourself to anything you'd like

@MizuhoOkimoto
Copy link
Contributor

Thank you for your reply! I changed the padding so that I will make a PR soon. I'm new here, so I'm not sure how to work for the "Additional context". Could you please explain what I should do?

MizuhoOkimoto added a commit to MizuhoOkimoto/atomic-react that referenced this issue Oct 30, 2021
@frattaro
Copy link
Contributor Author

So when you add the PR the tests will run and should fail, because the snapshot images will be different. Those snapshot images are updated via github action.

I took a screenshot from over in the Actions tab. On the left side, clicking "Update Snapshots" and then on the right side choosing your branch. When the workflow runs, it'll update the snapshots and commit the change to the branch you selected.

image

@MizuhoOkimoto
Copy link
Contributor

Thank you for your detailed explanation! I made a PR, and the snapshot is updating now!

@frattaro frattaro mentioned this issue Nov 1, 2021
5 tasks
MizuhoOkimoto added a commit to MizuhoOkimoto/atomic-react that referenced this issue Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants