-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrolling tabs focused tab display issue #987
Comments
Hi, may I work on it? I appreciate it if you assign it to me. |
@MizuhoOkimoto Everything is up for grabs, feel free to assign yourself to anything you'd like |
Thank you for your reply! I changed the padding so that I will make a PR soon. I'm new here, so I'm not sure how to work for the "Additional context". Could you please explain what I should do? |
So when you add the PR the tests will run and should fail, because the snapshot images will be different. Those snapshot images are updated via github action. I took a screenshot from over in the |
Thank you for your detailed explanation! I made a PR, and the snapshot is updating now! |
Describe the bug
When a tab in scrolling tabs is focused, the top border isn't appearing:
To Reproduce
Steps to reproduce the behavior:
Go here: https://atomic-react.security.cisco.com/components/tab#scrolling
click a tab, see missing top border
Expected behavior
The top border should be visible
Additional context
.a-tab-group__tab-content
needs 1px top padding. After the change is made, the github action workflowUpdate Snapshots
needs run on the published branch, and that should update the visual regression test assetsThe text was updated successfully, but these errors were encountered: