-
Notifications
You must be signed in to change notification settings - Fork 5
fix: show focus border for scrolling tabs #992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an entry in /framework/changelog.mdx? as
## 3.1.3 (pending)
- Fixed padding on scrolling tabs so focus border displays correctly
Hi @frattaro, I added the changelog inside the above file. I appreciate it if you can review it. Thank you! |
@MizuhoOkimoto Thanks, did it get pushed? |
Hi, @frattaro ! Yes, I pushed it. Was it okay to push...? |
I mean the changelog edits aren't showing up in this PR -- still only 2 commits. I'm not sure why it's not prompting me to approve the CI workflows for this PR either. If you can figure it out that's cool, if not I'd suggest abandoning the fork and cloning the repo and branching |
7801dd4
to
d11ca08
Compare
Hi @frattaro , I tried many ways to push my change(add: changelog 3.1.3), and I used force-push as a last resort. I usually don't want to use force/hard, but it was the last attempt before cloning the repo again. |
Can you pull in the latest? I added |
f3585a5
to
ec1c7bd
Compare
I'm going to merge this -- but it's strange that the CI workflow isn't running. I assume it's because it's from a fork. Can you please clone/branch next time? |
Hi @frattaro , thank you so much. Sorry for taking your time to check CI and this problem. I will make another fork and clone/branch next time! |
Thank you too, the contributions are much appreciated -- sorry for the road bumps :) |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Closes #987
Please see this page: https://atomic-react.security.cisco.com/components/tab#scrolling
When clicking a tab, the top border is missing.
I added padding-top 1px, so that the top border became visible.
Does this PR introduce a breaking change?
No
Other information:
![image](https://user-images.githubusercontent.com/54873998/139561420-20681a10-72c5-4e6e-b0fa-56a213c2d532.png)
Attached screenshot after fixing it.
If I need to improve or follow any rules to contribute, please let me know. Thank you very much!