Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG17 regress test sanity: fix diffs in union_pushdown. #7762

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

colm-mchugh
Copy link
Contributor

Preserve the test error message by adjusting the query so that PG17 cannot pull it up to a join. Another instance of a subquery that can be pulled up to a join with PG17 (#7745)

This should have been fixed in, but slipped by, #7745

@colm-mchugh colm-mchugh self-assigned this Nov 22, 2024
@colm-mchugh colm-mchugh changed the base branch from naisila/pg17_support to release-13.0 November 22, 2024 10:36
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-13.0@12dd9c1). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-13.0    #7762   +/-   ##
===============================================
  Coverage                ?   89.65%           
===============================================
  Files                   ?      274           
  Lines                   ?    59583           
  Branches                ?     7436           
===============================================
  Hits                    ?    53417           
  Misses                  ?     4034           
  Partials                ?     2132           
---- 🚨 Try these New Features:

Copy link
Member

@naisila naisila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks.
Reminder to drop the configure commit before merging.

Preserve the test error message by adjusting the query so that PG17
cannot pull it up to a join. Another instance of a subquery that can
be pulled up to a join with PG17 (#7745)
@colm-mchugh colm-mchugh merged commit 1d0111a into release-13.0 Nov 22, 2024
121 checks passed
@colm-mchugh colm-mchugh deleted the cmchugh/pg17-union_pushdown branch November 22, 2024 16:25
m3hm3t pushed a commit that referenced this pull request Nov 28, 2024
Preserve the test error message by adjusting the query so that PG17
cannot pull it up to a join. Another instance of a subquery that can be
pulled up to a join with PG17 (#7745)

This should have been fixed in, but slipped by, #7745
m3hm3t pushed a commit that referenced this pull request Nov 28, 2024
Preserve the test error message by adjusting the query so that PG17
cannot pull it up to a join. Another instance of a subquery that can be
pulled up to a join with PG17 (#7745)

This should have been fixed in, but slipped by, #7745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants