Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Broken and old links in VZV and VZE #1431

Merged
merged 2 commits into from
May 1, 2024
Merged

Fix Broken and old links in VZV and VZE #1431

merged 2 commits into from
May 1, 2024

Conversation

roseeichelmann
Copy link
Contributor

@roseeichelmann roseeichelmann commented Apr 11, 2024 •
edited
Loading

Associated issues

Closes cityofaustin/atd-data-tech#16768

Testing

URL to test:
VZV and VZE

Steps to test:

  1. First test the VZV, check that the link to the CR3 police manual links to the 2024 version now.
  2. Also test that the link at the footer to our website works.
  3. Now test the VZE deploy, test that the link to our website at the bottom works.

Ship list

  • Check migrations for any conflicts with latest migrations in master branch
  • Confirm Hasura role permissions for necessary access
  • Code reviewed
  • Product manager approved

chiaberry
chiaberry reviewed Apr 11, 2024
View reviewed changes
atd-vze/src/containers/DefaultLayout/DefaultFooter.js
@@ -20,8 +20,8 @@ class DefaultFooter extends Component {
</span>
<span className="ml-auto">
Powered by{" "}
<a href="https://transportation.austintexas.io/about/">
ATD Data & Technology Services
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

mddilley
mddilley approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@mddilley mddilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviving these links! Test steps check out. 🙌 :shipit:

frankhereford
frankhereford approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@frankhereford frankhereford left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛓️ 🧹 👍 🚢 🙏

johnclary
johnclary approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@johnclary johnclary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these links were very broken and old. thank you! 🚢 🚢 🚢 🚢 🚢 🚢 🚢

@roseeichelmann roseeichelmann merged commit a450e47 into master May 1, 2024
8 checks passed
@roseeichelmann roseeichelmann deleted the 16768_fix_vzv_links branch May 1, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mddilley mddilley mddilley approved these changes

@johnclary johnclary johnclary approved these changes

@chiaberry chiaberry chiaberry approved these changes

@frankhereford frankhereford frankhereford approved these changes

@tillyw tillyw Awaiting requested review from tillyw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Broken and old links in the VZV
5 participants
@roseeichelmann @frankhereford @chiaberry @johnclary @mddilley