Remove unused components from VZE #1483
Conversation
…ilter-update bump paths-filter version and use setting
Set minimum crash date to be OCR'd to 2020-01-01
Small VZV timestamp bug
roseeichelmann
requested review from
frankhereford,
chiaberry,
johnclary,
tillyw and
mddilley
|
@roseeichelmann would you mind pointing this PR against |
There was a problem hiding this comment.
I tested this locally after merging it with the data model collector branch—all looks great!
I guess, fwiw, it might actually be helpful to preserve all of this for a future product manager who wanted to browse all the UI components, but I would rather see a tool like this hosted in a separate fork or something. As it is, this feature bogs down the code base and I'm very happy to see it removed.
It looks like there are a few more files/routes that can be deleted, then this will be good to go! 🙌
atd-vze/src/routes.js
Outdated
| @@ -71,70 +42,6 @@ const routes = roles => [ | |||
| { path: "/dev/theme", exact: true, name: "Theme", component: Colors }, | |||
There was a problem hiding this comment.
any reason not to get rid of these other pieces? Notifications, Theme, Dev...?
There was a problem hiding this comment.
@roseeichelmann I'm getting this error when starting VZE. I merged the latest from data-model-v2, but maybe I should be pulling some newer code in from somewhere. Let me know, and I'll turn this into an approval.
There was a problem hiding this comment.
oops—it does appear some of those widgets were load bearing 😮
There was a problem hiding this comment.
thanks for catching that mike! i just brought back the two widgets we actually use
|
Almost certainly a product of the merge party 🥳, but I saw this one compile warning. 
|
ah yes—i saw that this is already fixed in the soft deletes branch 👍 🙏 |
Associated issues
Closes cityofaustin/atd-data-tech#17392
Ended up finding a lot more unused components than just the Charts
Testing
URL to test:
Locally
Steps to test:
Ship list