-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up ETL directory and Docker image CI #1511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the export locally, and it succeeded. I read through the file updates and deletions. Nothing sticks out to me, and I think the GH action diff looks good too. 🚢 💨
@@ -1 +1,3 @@ | |||
env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to remember to delete our existing env
files since only .env
is ignored at the top level of the project. I just did mine because I'm paranoid that I'll forget and accidentally leak my 1PW token.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah—thank you. i had the luxury of deleting the old directory and renaming the new directory, so didn't encounter this. i just added env
to the root .gitignore
and i will add note to the test steps to remove that. will also drop a note in slack post-go-live
Set VZV dataset endpoints based on environment
Associated issues
Testing
atd-etl/data_model/.env
env
filed fro./atd-etl/cris_import
and save your.env
file there./atd-etl/cris_import
:docker run -it --rm --env-file .env --network host -v $PWD:/app data_model_cris_import ./cris_import.py --csv --pdf --s3-download --verbose