Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organizations Index Contributor check box denoted in URL #1042

Closed
1 task
ladissi opened this issue Nov 11, 2021 · 1 comment · Fixed by #1070 or #1136
Closed
1 task

Organizations Index Contributor check box denoted in URL #1042

ladissi opened this issue Nov 11, 2021 · 1 comment · Fixed by #1070 or #1136
Assignees
Labels
p-feature: Organizations Everything relating to Organizations page role: front end size: 3pt Can be done in about 18 hours

Comments

@ladissi
Copy link

ladissi commented Nov 11, 2021

Overview

Organizations page Index Contributor check box should be logged in URL so when URL is sent to others they will be able to access the organizations page with the Index Contributor checkbox checked.

Action Items

  • when clicking Index Contributor checkbox, log into URL so when URL is shared folks who open the URL also have checkbox checked

Resources/Instructions

Screen Shot 2021-11-10 at 7 38 51 PM

@ladissi ladissi added role: front end p-feature: Organizations Everything relating to Organizations page size: 1pt Can be done in 6 hours or less labels Nov 11, 2021
@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Jan 20, 2022

We have reopened this issue because it has not passed QA for requirements

User Story

As a user I want to be able to bookmark various states of the Contributions page. If I select any number of options, when I bookmark that, it should come back to that same set of options or choices I have made.

Technical details

Ultimately we want the whole interface to use the URL bar to store arguments about state (just like google maps does). However, in order to get to launch we can fix the site using the current methodology, but all the links must somehow reflect in the URL bar.

What is working, and not working and how to replicate

It looks like the items in the menu are working
http://civictechindex.org/organizations/all
http://civictechindex.org/organizations/affiliated
http://civictechindex.org/organizations/unaffiliated
http://civictechindex.org/organizations/contributors

But when you get onto the page, clicking any of the subnav does not change the url in the bar, so bookingmarking is still not going to work.

To replicate error
See image below

  1. Go to site
  2. click Unaffiliated
  3. Bookmark it
  4. Visit Bookmark
  5. Notice that you will end up at the ALL contributors view again

image

Also, here is an example where we did the following

  1. Clicked on Unaffiliated on the top nav
  2. clicked on Affiliated in the page nav
  3. clicked on Index Contributor box
    image

@kevindphan kevindphan added size: 3pt Can be done in about 18 hours and removed size: 1pt Can be done in 6 hours or less labels Jan 28, 2022
@bruceplai bruceplai self-assigned this Jan 29, 2022
bruceplai added a commit that referenced this issue Jan 29, 2022
* Clean up routes in App.js

* Add query params to navigation.js

* Update header and footer link lists to handle query params

* Update Organizations page to handle contrib and status params

* Update Organizations page to handle various nav scenarios
bruceplai added a commit that referenced this issue Jan 29, 2022
* Clean up routes in App.js

* Add query params to navigation.js

* Update header and footer link lists to handle query params

* Update Organizations page to handle contrib and status params

* Update Organizations page to handle various nav scenarios
bruceplai added a commit that referenced this issue Jan 30, 2022
* Clean up header.spec.js

* Move footer.spec.js
bruceplai added a commit that referenced this issue Jan 30, 2022
bruceplai added a commit that referenced this issue Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-feature: Organizations Everything relating to Organizations page role: front end size: 3pt Can be done in about 18 hours
Projects
Status: New Issue Approval (All new issues should be added to this column)
5 participants