-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sub-menu Organization Page #1070
Conversation
@@ -27,7 +27,7 @@ describe('Contributors Page (using API)', () => { | |||
|
|||
it('should find affiliatedOrg via search', () => { | |||
cy.intercept(`${Cypress.env('REACT_APP_API_URL')}/api/organizations/`).as('getOrganizations'); | |||
cy.visit('/organizations/affiliated'); | |||
cy.visit('/organizations/all'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to change this route to /all ?
@@ -47,7 +47,7 @@ describe('Contributors Page (using API)', () => { | |||
cy.intercept(`${Cypress.env('REACT_APP_API_URL')}/api/organizations/`).as( | |||
'getOrganizations' | |||
); | |||
cy.visit('/organizations/affiliated'); | |||
cy.visit('/organizations/all'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to change this route to /all ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is failing if it is affiliated. To pass the test I gave this
@@ -79,7 +79,7 @@ describe('Contributors Page (using fixture)', () => { | |||
cy.intercept(`${Cypress.env('REACT_APP_API_URL')}/api/organizations/`, { | |||
fixture: 'orgs.json', | |||
}); | |||
cy.visit('/organizations/'); | |||
cy.visit('/organizations/all'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to change this route to /all ?
@@ -115,8 +115,7 @@ const NotableUsersSection = () => { | |||
<NavButton | |||
color='primary' | |||
href={{ | |||
pathname: '/organizations/affiliated', | |||
query: { contributor: true }, | |||
pathname: '/organizations/contributors', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a minor update to code style
const MoreContributors = () => {
return (
<Grid item xs={12} style={{ padding: '30px' }}>
<div align='center'>
<NavButton
color='primary'
href={{ pathname: '/organizations/contributors' }}
>
View contributors
</NavButton>
</div>
</Grid>
);
};
Code Climate has analyzed commit add35ff and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 81.6% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Thanks
Closes #1040
Closes #1042