Sub-menu Organization Page #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruceplai
reviewed
Nov 16, 2021
| @@ -27,7 +27,7 @@ describe('Contributors Page (using API)', () => { | |||
|
|
|||
| it('should find affiliatedOrg via search', () => { | |||
| cy.intercept(`${Cypress.env('REACT_APP_API_URL')}/api/organizations/`).as('getOrganizations'); | |||
| cy.visit('/organizations/affiliated'); | |||
| cy.visit('/organizations/all'); | |||
There was a problem hiding this comment.
Is there a reason to change this route to /all ?
bruceplai
reviewed
Nov 16, 2021
| @@ -47,7 +47,7 @@ describe('Contributors Page (using API)', () => { | |||
| cy.intercept(`${Cypress.env('REACT_APP_API_URL')}/api/organizations/`).as( | |||
| 'getOrganizations' | |||
| ); | |||
| cy.visit('/organizations/affiliated'); | |||
| cy.visit('/organizations/all'); | |||
There was a problem hiding this comment.
Is there a reason to change this route to /all ?
There was a problem hiding this comment.
The test is failing if it is affiliated. To pass the test I gave this
bruceplai
reviewed
Nov 16, 2021
| @@ -79,7 +79,7 @@ describe('Contributors Page (using fixture)', () => { | |||
| cy.intercept(`${Cypress.env('REACT_APP_API_URL')}/api/organizations/`, { | |||
| fixture: 'orgs.json', | |||
| }); | |||
| cy.visit('/organizations/'); | |||
| cy.visit('/organizations/all'); | |||
There was a problem hiding this comment.
Is there a reason to change this route to /all ?
bruceplai
reviewed
Nov 16, 2021
| @@ -115,8 +115,7 @@ const NotableUsersSection = () => { | |||
| <NavButton | |||
| color='primary' | |||
| href={{ | |||
| pathname: '/organizations/affiliated', | |||
| query: { contributor: true }, | |||
| pathname: '/organizations/contributors', | |||
There was a problem hiding this comment.
Looks good. Just a minor update to code style
const MoreContributors = () => {
return (
<Grid item xs={12} style={{ padding: '30px' }}>
<div align='center'>
<NavButton
color='primary'
href={{ pathname: '/organizations/contributors' }}
>
View contributors
</NavButton>
</div>
</Grid>
);
};
|
Code Climate has analyzed commit add35ff and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 81.6% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1040
Closes #1042