Fix format normalization configuration #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* because the values in the ini file are interpreted as string * Fix tests and add test for format normalization
|
@amercader or @metaodi Maybe one of you will find time to have a look at this PR? Thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to deactivate the ckan format normalization by config. But we are surprised that the config parameter
ckanext.dcat.normalize_ckan_formatseems to be ignored. We invested some time and found out the reason.The reason is that the config parameter was read from the config file but was interpreted as string what is still the default behavior for an ini file. So, the value
Falsein the config file was interpreted as string'False'and not as boolean what will lead to the situation that the expressionand normalize_ckan_formatwas always True, because a not empty string is interpreted as True.The pull request adds the conversion of the param to type boolean.