Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the possibility to modify package update/create schema #176

Conversation

seitenbau-govdata
Copy link
Member

@seitenbau-govdata seitenbau-govdata commented Feb 7, 2020

We want to deactivate the email validation for the fields author_email and maintainer_email, because we would not like to reject the import of a dataset if the email address is invalid.

The pull request introduces the possibility to modify/overwrite the update/create package schema used in the harvest process updating/creating datasets. This can be done by implementing the new interface methods update_package_schema_for_create and update_package_schema_for_update.

@seitenbau-govdata seitenbau-govdata force-pushed the introduce-possibility-to-modify-overwrite-package-update-create-schema branch from 5b45246 to 6c517b2 Compare February 7, 2020 16:01
@amercader
Copy link
Member

This sounds useful, I might steal it for other harvesters! My only concern is that we will now have two ways in which harvesters can be extended, inheriting from this base class and overriding the _get_create/update_package_schema methods or implementing the IDCATRDFHarvester interface (which implements after/before_update/create).

Perhaps for consistency we can add new methods to that interface?

@seitenbau-govdata
Copy link
Member Author

Good point, @amercader ! We will try to change it and make use of the IDCATRDFHarvester interface.

@seitenbau-govdata seitenbau-govdata force-pushed the introduce-possibility-to-modify-overwrite-package-update-create-schema branch from 6c517b2 to 8475585 Compare February 19, 2020 15:18
@seitenbau-govdata
Copy link
Member Author

@amercader I have changed the pull request to using interface methods. Please review again. :-)

@amercader amercader merged commit e9d397a into ckan:master Feb 22, 2020
amercader added a commit that referenced this pull request Feb 25, 2020
@seitenbau-govdata seitenbau-govdata deleted the introduce-possibility-to-modify-overwrite-package-update-create-schema branch November 5, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants