-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps #69
Update deps #69
Conversation
"@types/jasminewd2": "^2.0.3", | ||
"codelyzer": "^4.4.2", | ||
"coveralls": "^3.0.2", | ||
"fs-extra": "^7.0.0", | ||
"jasmine-core": "^3.2.1", | ||
"jasmine-spec-reporter": "^4.2.1", | ||
"karma": "^3.0.0", | ||
"karma": "^4.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to bump the Karma version, you need to bump supported Node version (engines.node
). See karma-runner/karma#3151.
cc: @Reinmar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the one hand, it's mainly for internal usage. On the other hand, I've just installed the latest angular sample app and it's using karma@3.1.1
. Do we have somewhere define when we drop node@6 support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't. I've just created a ticket about bumping the Node version (ckeditor/ckeditor5#1507).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see from the official Node.js
page (https://github.com/nodejs/Release) that they will drop support for node@6 in April 2019.
R- until resolving the node version issue (#69 (comment)). |
I'll bump versions of Node and NPM on master. |
Suggested merge commit message (convention)
Internal: Updated dependencies. Closes #68.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.