Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #69

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Update deps #69

merged 1 commit into from
Feb 12, 2019

Conversation

ma2ciek
Copy link
Contributor

@ma2ciek ma2ciek commented Feb 4, 2019

Suggested merge commit message (convention)

Internal: Updated dependencies. Closes #68.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 212

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 201: 0.0%
Covered Lines: 119
Relevant Lines: 119

💛 - Coveralls

"@types/jasminewd2": "^2.0.3",
"codelyzer": "^4.4.2",
"coveralls": "^3.0.2",
"fs-extra": "^7.0.0",
"jasmine-core": "^3.2.1",
"jasmine-spec-reporter": "^4.2.1",
"karma": "^3.0.0",
"karma": "^4.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to bump the Karma version, you need to bump supported Node version (engines.node). See karma-runner/karma#3151.

cc: @Reinmar

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the one hand, it's mainly for internal usage. On the other hand, I've just installed the latest angular sample app and it's using karma@3.1.1. Do we have somewhere define when we drop node@6 support?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't. I've just created a ticket about bumping the Node version (ckeditor/ckeditor5#1507).

Copy link
Contributor Author

@ma2ciek ma2ciek Feb 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see from the official Node.js page (https://github.com/nodejs/Release) that they will drop support for node@6 in April 2019.

@Reinmar Reinmar requested a review from pomek February 12, 2019 11:28
@pomek
Copy link
Member

pomek commented Feb 12, 2019

R- until resolving the node version issue (#69 (comment)).

@pomek
Copy link
Member

pomek commented Feb 12, 2019

I'll bump versions of Node and NPM on master.

@pomek pomek merged commit e4a642d into master Feb 12, 2019
@pomek pomek deleted the t/68 branch February 12, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants