Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #69

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Update deps #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,33 +30,33 @@
"zone.js": "^0.8.26"
},
"devDependencies": {
"@angular-devkit/build-angular": "~0.10.3",
"@angular-devkit/build-angular": "~0.13.0",
"@angular/cli": "^7.0.3",
"@angular/compiler-cli": "^7.0.1",
"@angular/language-service": "^7.0.1",
"@ckeditor/ckeditor5-build-classic": "^11.1.1",
"@ckeditor/ckeditor5-dev-env": "^13.0.0",
"@ckeditor/ckeditor5-dev-utils": "^11.0.0",
"@types/jasmine": "^2.8.8",
"@types/jasmine": "^3.3.8",
"@types/jasminewd2": "^2.0.3",
"codelyzer": "^4.4.2",
"coveralls": "^3.0.2",
"fs-extra": "^7.0.0",
"jasmine-core": "^3.2.1",
"jasmine-spec-reporter": "^4.2.1",
"karma": "^3.0.0",
"karma": "^4.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to bump the Karma version, you need to bump supported Node version (engines.node). See karma-runner/karma#3151.

cc: @Reinmar

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the one hand, it's mainly for internal usage. On the other hand, I've just installed the latest angular sample app and it's using karma@3.1.1. Do we have somewhere define when we drop node@6 support?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't. I've just created a ticket about bumping the Node version (ckeditor/ckeditor5#1507).

Copy link
Contributor Author

@ma2ciek ma2ciek Feb 5, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see from the official Node.js page (https://github.com/nodejs/Release) that they will drop support for node@6 in April 2019.

"karma-browserstack-launcher": "^1.3.0",
"karma-chrome-launcher": "^2.2.0",
"karma-coverage-istanbul-reporter": "^2.0.1",
"karma-firefox-launcher": "^1.1.0",
"karma-jasmine": "^1.1.2",
"karma-jasmine": "^2.0.1",
"karma-jasmine-html-reporter": "^1.3.1",
"ng-packagr": "^4.0.0",
"protractor": "^5.4.0",
"ts-node": "^7.0.0",
"tsickle": "^0.33.1",
"ts-node": "^8.0.2",
"tsickle": "^0.34.3",
"tslint": "^5.11.0",
"typescript": "~3.1.3"
"typescript": "~3.2.4"
},
"engines": {
"node": ">=6.0.0",
Expand Down