Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Table selection handler should not be truncated inside a block quote. #30

Closed
wants to merge 2 commits into from

Conversation

dkonopka
Copy link

@dkonopka dkonopka commented Jan 15, 2019

Suggested merge commit message (convention)

Fix: Table selection handler should not be truncated inside a block quote. Closes: ckeditor/ckeditor5#3322


Additional information

Because of no Edge support we can't use such CSS syntax:

.ck-content blockquote .table:first-child {
  margin-top: calc( 1em + var(--ck-widget-handler-icon-size) );
}

@dkonopka dkonopka requested a review from oleq January 15, 2019 14:18
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 07e76e4 on t/28 into 9934159 on master.

@oleq
Copy link
Member

oleq commented Jan 16, 2019

Q: Why is

.ck-content blockquote {
    overflow: hidden;
}

in the first place?

It's because ckeditor/ckeditor5-image#140 (comment).

@oleq
Copy link
Member

oleq commented Jan 16, 2019

I was wondering... this whole thing is totally related to the UI, not to the content. For instance, when the editor is destroyed and .ck-content styles are still in use (inline editors), this would look weird.

Another thing is, it only takes a single change to --ck-widget-handler-icon-size, and the content styles blow up and we have a regression.

So, what about using UI styles instead of content styles with --ck-widget-handler-icon-size in calc()?

@oleq
Copy link
Member

oleq commented Jan 16, 2019

BTW, there's also this case

image

@jodator
Copy link
Contributor

jodator commented Jan 16, 2019

BTW, there's also this case

And that ;) https://github.com/ckeditor/ckeditor5-widget/issues/44

@dkonopka
Copy link
Author

I'll fix it in ckeditor5-theme-lark repo.

@dkonopka dkonopka closed this Jan 17, 2019
@dkonopka dkonopka deleted the t/28 branch January 17, 2019 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The table selector is truncated when in block quote
4 participants