Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat dependencies in the dist folder as production dependencies. #964

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

filipsobol
Copy link
Member

@filipsobol filipsobol commented Jul 2, 2024

Suggested merge commit message (convention)

Fix (dependency-checker): Treat dependencies in the dist folder as production dependencies. See ckeditor/ckeditor5#16646.

Other (build-tools): The .d.ts files for translations should import directly from @ckeditor/ckeditor5-utils instead of ckeditor5. See ckeditor/ckeditor5#16646.

MINOR BREAKING CHANGE: Treat dependencies in the dist folder as production dependencies.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@coveralls
Copy link

Coverage Status

coverage: 90.624%. remained the same
when pulling 1a65fcf on treat-deps-in-dist-folder-as-prod-deps
into 9c5adde on master.

@coveralls
Copy link

Coverage Status

coverage: 90.624%. remained the same
when pulling ca6bb58 on treat-deps-in-dist-folder-as-prod-deps
into 9c5adde on master.

@filipsobol filipsobol requested a review from pomek July 5, 2024 07:06
@coveralls
Copy link

Coverage Status

coverage: 90.624%. remained the same
when pulling 4d7745a on treat-deps-in-dist-folder-as-prod-deps
into 9c5adde on master.

@filipsobol filipsobol requested a review from pomek July 8, 2024 07:45
@coveralls
Copy link

coveralls commented Jul 8, 2024

Coverage Status

coverage: 90.624%. remained the same
when pulling 99fa293 on treat-deps-in-dist-folder-as-prod-deps
into 9c5adde on master.

@filipsobol filipsobol merged commit 09d304f into master Jul 22, 2024
3 checks passed
@filipsobol filipsobol deleted the treat-deps-in-dist-folder-as-prod-deps branch July 22, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants