-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat dependencies in the dist
folder as production dependencies.
#964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…production dependencies.
pomek
reviewed
Jul 3, 2024
packages/ckeditor5-dev-dependency-checker/lib/checkdependencies.js
Outdated
Show resolved
Hide resolved
pomek
reviewed
Jul 8, 2024
pszczesniak
reviewed
Jul 19, 2024
pszczesniak
approved these changes
Jul 19, 2024
pomek
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (dependency-checker): Treat dependencies in the
dist
folder as production dependencies. See ckeditor/ckeditor5#16646.Other (build-tools): The
.d.ts
files for translations should import directly from@ckeditor/ckeditor5-utils
instead ofckeditor5
. See ckeditor/ckeditor5#16646.MINOR BREAKING CHANGE: Treat dependencies in the
dist
folder as productiondependencies
.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.