Add dependencies used in the new dist folder as production dependencies
#16649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pendencies` instead of `devDependencies`.
pszczesniak
reviewed
Jul 4, 2024
There was a problem hiding this comment.
As we discussed internally, proabably best solution is to have the dependency-checker task run while preparing the release. This is caused by this, that each package must be built and has to had it's own dist folder. As we know it's not obvious to force it locally, so the best place is to do it on CI while release process is firing.
When some package has not got a dist folder - results of dependency-checker will be wrong.
cc @pomek
|
Will be continued in #16749. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Add dependencies used in the new
distfolder as productiondependenciesinstead ofdevDependencies. Related to #16646.Additional information
Blocked by ckeditor/ckeditor5-dev#964.