T/ckeditor5/998: Mentions MVP

[jodator]

Feature: The mentions feature. Closes ckeditor/ckeditor5#998.

--

• there are two undo integration tests that fails (Weird case with attribute removal in model post-fixer ckeditor5#1645)
• follow-ups:
  • debounce the UI
  • extract TextWatcher plugin
  • prepare the autocomplete guide
  • finish feature guide

Edit: I've moved the styles to theme lark. The required PR is here: ckeditor/ckeditor5-theme-lark#221.

[jodator]

Since the PR is still open I've added the feature guide stub. I'll expand it tomorrow.

[dkonopka]

1. We should keep balloon position "stick" to the line-height of text. Is it by default that 2-3px of top difference or just bug?

2. Are we going to have this following caret panel in MVP?
   

3. We should add default color/background support for mention inside theme-lark, this reddish is IMHO a good choice. We need to remember about adding these variables to the guide.

:root {
    --ck-color-mention-background: hsla(341, 100%, 30%, 0.1);
    --ck-color-mention-text: hsl(341, 100%, 30%);
}

4. Take a look here:
   4.1. I see some issues with balloon positioning
   4.2 Trying to mention someone without a space before @. Is it by design?

5. One more thing, I'm not sure if "it's a bug or a feature" 😄
   

[jodator]

1. Trying to mention someone without a space before `@`. Is it by design?

yes - might be changed but this also covers:

• @@@@
• user@example.com

[Reinmar]

1. Are we going to have this following caret panel in MVP?

I think we agreed it should stick to @ even in MVP. This is definitely a critical followup for me.

[jodator]

@Reinmar I see some follow-ups reported is this PR to be closed or something needs updating before merge?

[jodator]

We should keep balloon position "stick" to the line-height of text. Is it by default that 2-3px of

Will be fixed with #7.

Are we going to have this following caret panel in MVP?

in #7

We should add default color/background support for mention inside

I'll add it in this PR: ckeditor/ckeditor5-theme-lark#221.

One more thing, I'm not sure if "it's a bug or a feature" smile

Removing mention on typing - feature ;)

[Reinmar]

I confirm that it works 🎉

Will review the rest once it's on master.

[Reinmar]

@jodator, could you open tickets for all the remaining issues that were mentioned in this PR?

[robclancy]

Where is this on a roadmap for release? We need this soon and I want to know if I should just wait for a stable release or bring this in manually for now.

[mlewand]

@robclancy we plan to do npm release later this week. So it's just around the corner. Either keep an eye on npm or just subscribe to releases of this package on GH and you'll get notified as soon as we publish it.