-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird case with attribute removal in model post-fixer #1645
Comments
ps.: The same happens on FF and Chrome. |
I confirm the bug. Quick observation: when removing, always the last letter is removed, unless the first letter is removed. When typing, the typing itself is fine but undo fails. |
This is a bug in |
Okaaay, so ckeditor/ckeditor5-engine#1705 this fixes the issue with However, this does not fix not-bolding on undo. In fact, everything works correctly. The bold is applied, but since also there is a letter inserted (or removed) during the undo, the bold is immediately taken off. So the post-fixer like this for mentions is not correct. |
Fix: Attribute and remove change on intersecting ranges done in the same change block will be correctly saved in `Differ` and downcasted. Closes ckeditor/ckeditor5#1645.
Is this a bug report or feature request? (choose one)
🐞 Bug report
💻 Version of CKEditor
latest master
📋 Steps to reproduce
bold
l
(forward or backward delete)<paragraph><$text bold="true">bo[]d</$text></paragraph>
<p>bo[]l</p>
✅ Expected result
The text after deletion is
bod
in the view.The text after undo id
bold
in the view.The text after undo has
bold
attribute in the model.❎ Actual result
The text after deletion in the editing area is
bol
.The text after undo id
boll
in the view.The text after undo doesn't have
bold
attribute.📃 Other details that might be useful
Screen cast:
The text was updated successfully, but these errors were encountered: