Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cutting a table cell after triple click throws an error #3167

Closed
Reinmar opened this issue May 24, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1431 or ckeditor/ckeditor5-table#39
Closed

Cutting a table cell after triple click throws an error #3167

Reinmar opened this issue May 24, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1431 or ckeditor/ckeditor5-table#39
Assignees
@jodator
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 18

Comments

@Reinmar
Copy link
Member

Reinmar commented May 24, 2018

A triple click is not handled by us yet because we don't support cell selection in MVP1, but what we need to do now is:

  • validate the selection – selection should not span a table cell, it needs to be contained inside it;
  • make sure that cut does not throw such an error anyway (for the future);
  • report crash which happens on ctx menu opening to Blink.

Steps (recorded):

  1. Triple-click.
  2. Right click... browser crash.
  3. Reload.
  4. Triple-click.
  5. Cmd+X... editor crash.

may-24-2018 12-39-04
@jodator jodator self-assigned this Jun 12, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-engine Jun 18, 2018
@Reinmar
Merge pull request #1431 from ckeditor/t/ckeditor5-table/12
6cf91a1 
Feature: Introduced a selection post-fixer. Its role is to ensure that after all changes are applied the selection is placed in a correct position. Closes #1156. Closes #1176. Closes #1182. Closes ckeditor/ckeditor5-table#11. Closes ckeditor/ckeditor5-table#12. Closes ckeditor/ckeditor5-table#15. Closes ckeditor/ckeditor5#562. Closes ckeditor/ckeditor5#611.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the iteration 18 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:table labels Oct 9, 2019
This was referenced Oct 11, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 18
3 participants
@Reinmar @jodator @mlewand