Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with backwards selection around images #611

Closed
oleq opened this issue Oct 17, 2017 · 5 comments · Fixed by ckeditor/ckeditor5-engine#1431
Closed

Problems with backwards selection around images #611

oleq opened this issue Oct 17, 2017 · 5 comments · Fixed by ckeditor/ckeditor5-engine#1431
Labels
package:engine package:image type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@oleq
Copy link
Member

oleq commented Oct 17, 2017

I'm not sure if it's an engine or image issue, so posting it here. Browser is Google Chrome 61.

Case 1

  1. In a sample with an image in the content https://docs.ckeditor.com/ckeditor5/latest/examples/builds/classic-editor.html move the caret after the image (before<image>after[]).
  2. Shift+Arrow up to select the content after the image, the image and content before it.

kapture 2017-10-17 at 12 40 05

Expected:

[before<image>after]

Actual:

The selection collapses to the beginning of editable

[]before<image>after

Note: Forward selection works fine.

Case 2

  1. In a sample with an image in the content https://docs.ckeditor.com/ckeditor5/latest/examples/builds/classic-editor.html move the caret after the image (before<image>after[])
  2. Using the mouse (MacBook touchpad in the screencast) select the content after the image, the image and content before it.

kapture 2017-10-17 at 12 42 02

Expected:

[before<image>after]

Actual:

The image and the content flicker like possessed by a demon.

@oleq oleq added candidate:1.0.0 package:engine package:image type:bug This issue reports a buggy (incorrect) behavior. labels Oct 17, 2017
@Reinmar
Copy link
Member

Reinmar commented Oct 17, 2017

@szymonkups is already working on it.

@oleq
Copy link
Member Author

oleq commented Oct 17, 2017

That's a great news actually!

@scofalik
Copy link
Contributor

Related: https://github.com/ckeditor/ckeditor5-engine/issues/1156 ? Further comments concern not only FF.

@oleq
Copy link
Member Author

oleq commented Oct 20, 2017

@szymonkups Can you refer to the issue which is supposed to close this one?

@szymonkups
Copy link
Contributor

szymonkups commented Nov 8, 2017

Flickering from Case 2 should be now fixed by https://github.com/ckeditor/ckeditor5-image/issues/19. But still you'll be not able to select the whole content because selection lands in the nested editable, it is reported here: https://github.com/ckeditor/ckeditor5-image/issues/108.

Looks like Case 1 needs more investigation as it might be a separate issue. I will report it in ckeditor5-image repository.

@Reinmar Reinmar added this to the backlog milestone Apr 5, 2018
@Reinmar Reinmar modified the milestones: backlog, iteration 18 Jun 18, 2018
Reinmar added a commit to ckeditor/ckeditor5-engine that referenced this issue Jun 18, 2018
Feature: Introduced a selection post-fixer. Its role is to ensure that after all changes are applied the selection is placed in a correct position. Closes #1156. Closes #1176. Closes #1182. Closes ckeditor/ckeditor5-table#11. Closes ckeditor/ckeditor5-table#12. Closes ckeditor/ckeditor5-table#15. Closes ckeditor/ckeditor5#562. Closes ckeditor/ckeditor5#611.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine package:image type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants