Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FF] The caret appears at the top of the editor after right-click on the not focused editable #562

Closed
Mgsy opened this issue Sep 18, 2017 · 7 comments · Fixed by ckeditor/ckeditor5-engine#1431
Assignees
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Mgsy
Copy link
Member

Mgsy commented Sep 18, 2017

Steps to reproduce

  1. Go to http://localhost:8125/ckeditor5-presets/tests/manual/article.html.
  2. Don't focus the editor.
  3. Right-click on the editor.

Current result

The caret has appeared at the top of the editor.

GIF

bug_cke5

Other information

OS: Windows 10, MacOS X
Browser: Firefox
Release: 0.11.0

@Mgsy Mgsy added package:engine type:bug This issue reports a buggy (incorrect) behavior. labels Sep 18, 2017
@scofalik
Copy link
Contributor

The same will also happen if you focus toolbar and then click Tab. For some reason selection is incorrectly set before the first focus in editor.

@scofalik scofalik self-assigned this Sep 29, 2017
@scofalik
Copy link
Contributor

Actually, scratch that, FF just puts the selection in incorrect (for us, at least) place, when you focus the editable differently than left-mouse-key click. The same happens when you left click the editor, then click outside to blur it, click toolbar and use Tab.

@ma2ciek
Copy link
Contributor

ma2ciek commented Dec 12, 2017

I've checked, that FF puts the selection (both focusNode and anchorNode) at the contentEditable, instead of the first paragraph or something else. Should we move the selection to the first element inside the editor if the editor is selected? I see, that there's no trouble with it in the CKE4.

@Reinmar
Copy link
Member

Reinmar commented Dec 12, 2017

There's a great chance that ckeditor/ckeditor5-engine#1151 will fix it.

@ma2ciek
Copy link
Contributor

ma2ciek commented Dec 12, 2017

Oh, I didn't notice the PR.

@Reinmar Reinmar removed this from the iteration 14 milestone Feb 28, 2018
@Reinmar Reinmar added this to the backlog milestone Apr 5, 2018
@f1ames
Copy link
Contributor

f1ames commented Apr 6, 2018

Also it happens when focusing widget (left mouse button) without focusing the browser window first:

  1. Open Classic editor example.
  2. Refresh browser window (e.g. ctr/cmd + r).
  3. Click on image inside editor (it may require two clicks to focus image).

I just noticed it only happens with browser dev console opened.

ff3

@Reinmar
Copy link
Member

Reinmar commented May 14, 2018

#1010 also mention issues with an editor which contains only a <video>. It would be good to see where the editor places the selection in such a case. The only valid place will be around that video (if it's marked in the schema as an object).

Reinmar added a commit to ckeditor/ckeditor5-engine that referenced this issue Jun 18, 2018
Feature: Introduced a selection post-fixer. Its role is to ensure that after all changes are applied the selection is placed in a correct position. Closes #1156. Closes #1176. Closes #1182. Closes ckeditor/ckeditor5-table#11. Closes ckeditor/ckeditor5-table#12. Closes ckeditor/ckeditor5-table#15. Closes ckeditor/ckeditor5#562. Closes ckeditor/ckeditor5#611.
@Reinmar Reinmar modified the milestones: backlog, iteration 18 Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants