This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Editor crashed in some scenarios when mutations common ancestor could not be mapped to model #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Editor crashed in some scenarios when mutations common ancestor could not be mapped to model. Closes ckeditor/ckeditor5#718.
Additional information
I changed
VirtualTestEditor
toClassicTestEditor
in tests. Mutations handling functions useDomConverter
instance. However, inVirtualTestEditor
,DomConverter
is not used, so the tests, even though run green, were not accurate.After the change, I removed this
if
: https://github.com/ckeditor/ckeditor5-typing/pull/140/files#diff-8052e4286a369903aa5d7f6c2d8b7190L190It was covered only because the tests were using
VirtualTestEditor
. I cannot think of real case scenario where this could happen and all tests are green after removing it.