Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Editor crashed in some scenarios when mutations common ancestor could not be mapped to model #140

Merged
merged 3 commits into from
Feb 22, 2018

Conversation

scofalik
Copy link
Contributor

@scofalik scofalik commented Feb 21, 2018

Suggested merge commit message (convention)

Fix: Editor crashed in some scenarios when mutations common ancestor could not be mapped to model. Closes ckeditor/ckeditor5#718.


Additional information

I changed VirtualTestEditor to ClassicTestEditor in tests. Mutations handling functions use DomConverter instance. However, in VirtualTestEditor, DomConverter is not used, so the tests, even though run green, were not accurate.

After the change, I removed this if: https://github.com/ckeditor/ckeditor5-typing/pull/140/files#diff-8052e4286a369903aa5d7f6c2d8b7190L190

It was covered only because the tests were using VirtualTestEditor. I cannot think of real case scenario where this could happen and all tests are green after removing it.

@coveralls
Copy link

coveralls commented Feb 21, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 6eda231 on t/ckeditor5/718 into 430fcf7 on master.

@Reinmar Reinmar self-requested a review February 22, 2018 11:54
@Reinmar Reinmar merged commit db0fe8f into master Feb 22, 2018
@Reinmar Reinmar deleted the t/ckeditor5/718 branch February 22, 2018 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants