-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chrome, Edge] Exception after pressing CTRL + U while content is selected #718
Comments
This is a good one. I guess that a native underline comes into action and breaks our mutation observer. |
I wonder what's up, cause I can't reproduce it, while @Mgsy says that it is fixed for caption but still crashes for list items. EDIT: Okay, yeah, whatever, as usual it suddenly started to be broken for me aswell, but just after writing a comment. |
Although, when I click Cmd + U, I don't get an underline, instead I get this sign: ¨ and composition starts (I guess) and this crashes when there is a multielement selection. |
BTW, on my MacOS at least, with Polish Pro keyboard the keystroke which is worth testing is Alt+U. Pressing Alt+U enters umlaut composition. So Alt+U,U inserts "ü". This works fine on Firefox and Chrome in some cases now, but crashes on the two-lists-item-selection. After #140 it simply stops crashing in the two-lists-item-selection case, but it will do nothing in Chrome (in FF, it works fine). Which is fine for now. Let's see if anyone will ever report it. |
Fix: Editor should not crash in scenarios when mutations' common ancestor could not be mapped to the model. Closes ckeditor/ckeditor5#718.
Did you check if other keystrokes (Cmd+U, Ctrl+U) crash the editor? |
I tried all combinations with U. For some reason Ctrl+U crashes the editor on master, but at the same time, this keystroke has no action even here, in a textarea or in CKEditor 4. |
🐞 Is this a bug report or feature request? (choose one)
💻 Version of CKEditor
1.0.0-alpha2
📋 Steps to reproduce
Scenario 1
Scenario 2
✅ Expected result
Nothing happens.
❎ Actual result
There is the error in the console and in Chrome the selection has moved to the beginning of the document.
📃 Other details that might be useful
Error
GIF
Notes
It doesn't occur if the
underline
plugin is loaded.Other information
OS: Windows 10, MacOS X
Browser: Chrome, Edge
The text was updated successfully, but these errors were encountered: