Skip to content

Commit

Permalink
Merge branch i/6202-remove-env.isEdge to master.
Browse files Browse the repository at this point in the history
Internal: Removed mentions on Edge. See #6202.
  • Loading branch information
Reinmar committed Apr 20, 2020
2 parents bfe19b3 + 40c23ca commit 446170a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions packages/ckeditor5-engine/src/view/domconverter.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,7 @@ export default class DomConverter {
this._domToViewMapping.delete( domElement );
this._viewToDomMapping.delete( viewElement );

// Use Array.from because of MS Edge (#923).
for ( const child of Array.from( domElement.childNodes ) ) {
for ( const child of domElement.childNodes ) {
this.unbindDomElement( child );
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/ckeditor5-engine/tests/view/renderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -2056,7 +2056,7 @@ describe( 'Renderer', () => {

// Use a forgiving way of checking what the selection contains
// because Safari normalizes the selection ranges so precise checking is troublesome.
// Also, Edge returns a normal space instead of nbsp so we need to use even more alternatives.
// Also, Firefox returns a normal space instead of nbsp so we need to use even more alternatives.
function assertDomSelectionContents( domSelection, expectedContainer, expectedText ) {
const domSelectionContainer = domSelection.getRangeAt( 0 ).commonAncestorContainer;

Expand Down

0 comments on commit 446170a

Please sign in to comment.