Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we drop env.isEdge from our code base? #6202

Closed
jodator opened this issue Feb 6, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-utils#333
Closed

Should we drop env.isEdge from our code base? #6202

jodator opened this issue Feb 6, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-utils#333
Assignees
@tomalec
Labels
browser:edge intro Good first ticket. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 31 (v19...

Comments

@jodator
Copy link
Contributor

jodator commented Feb 6, 2020

Provide a description of the task

Thinking about new Edge - we have some conditional statements in features code and in tests code as well. Dropping this could be fun.
@jodator jodator added type:task This issue reports a chore (non-production change) and other types of "todos". browser:edge labels Feb 6, 2020
@Reinmar
Copy link
Member

Reinmar commented Feb 12, 2020

Oh, definitely. That, plus all occurrences.

@Reinmar Reinmar added this to the iteration 30 milestone Feb 12, 2020
@Reinmar Reinmar modified the milestones: iteration 30, next Feb 21, 2020
@Reinmar Reinmar added the intro Good first ticket. label Apr 6, 2020
@Reinmar Reinmar modified the milestones: next, iteration 31 Apr 15, 2020
@tomalec
Copy link
Contributor

tomalec commented Apr 17, 2020 •
edited
Loading

edit: questions moved to ckeditor/ckeditor5-utils#333

tomalec added a commit to ckeditor/ckeditor5-utils that referenced this issue Apr 17, 2020
@tomalec
Other: Remove env.isEdge. Closes ckeditor/ckeditor5#6202.
153f576 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.

BREAKING CHANGE: `env.isEdge` is no longer available in utils API, see #6202.
tomalec added a commit to ckeditor/ckeditor5-image that referenced this issue Apr 17, 2020
@tomalec
Other: Remove env.isEdge. Closes ckeditor/ckeditor5#6202.
d222fdf 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
tomalec added a commit to ckeditor/ckeditor5-engine that referenced this issue Apr 17, 2020
@tomalec
Other: Remove env.isEdge. Closes ckeditor/ckeditor5#6202.
366a63d 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
tomalec added a commit to ckeditor/ckeditor5-horizontal-line that referenced this issue Apr 17, 2020
@tomalec
Other: Remove env.isEdge. Closes ckeditor/ckeditor5#6202.
8f91c0d 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
tomalec added a commit to ckeditor/ckeditor5-media-embed that referenced this issue Apr 17, 2020
@tomalec
Other: Remove env.isEdge. Closes ckeditor/ckeditor5#6202.
2986a17 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
tomalec added a commit to ckeditor/ckeditor5-mention that referenced this issue Apr 17, 2020
@tomalec
Other: Remove env.isEdge. Closes ckeditor/ckeditor5#6202.
125c04d 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
tomalec added a commit to ckeditor/ckeditor5-page-break that referenced this issue Apr 17, 2020
@tomalec
Other: Remove env.isEdge. Closes ckeditor/ckeditor5#6202.
9fe1c69 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
tomalec added a commit to ckeditor/ckeditor5-paste-from-office that referenced this issue Apr 17, 2020
@tomalec
Other: Remove env.isEdge. Closes ckeditor/ckeditor5#6202.
f38afc0 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
tomalec added a commit to ckeditor/ckeditor5-table that referenced this issue Apr 17, 2020
@tomalec
Other: Remove env.isEdge. Closes ckeditor/ckeditor5#6202.
5cf3199 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
tomalec added a commit to ckeditor/ckeditor5-widget that referenced this issue Apr 17, 2020
@tomalec
Other: Remove env.isEdge. Closes ckeditor/ckeditor5#6202.
ac0e238 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
tomalec added a commit to ckeditor/ckeditor5-image that referenced this issue Apr 17, 2020
@tomalec
Other: Remove env.isEdge. Closes ckeditor/ckeditor5#6202.
48a810d 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
@tomalec tomalec mentioned this issue Apr 17, 2020
Merged
tomalec added a commit to ckeditor/ckeditor5-engine that referenced this issue Apr 20, 2020
@tomalec
Other: Remove Array.from needed for old Edge engine. ckeditor/ckedito…
67087ae 
…r5#6202

Use, plain `for ... of  .childNodes`, as agreed at ckeditor/ckeditor5-utils#333 (comment) .
tomalec added a commit to ckeditor/ckeditor5-engine that referenced this issue Apr 20, 2020
@tomalec
Other: Remove the Edge-specific assertion for a DOM selection. ckedit…
66b8a7f 
…or/ckeditor5#6202.

Agreed at ckeditor/ckeditor5-utils#333 (comment)
tomalec added a commit to ckeditor/ckeditor5-image that referenced this issue Apr 20, 2020
@tomalec
Other: Remove the Edge-specific fallback for image upload. ckeditor/c…
ab4a298 
…keditor5#6202.

Agreed at ckeditor/ckeditor5-utils#333 (comment)
tomalec added a commit to ckeditor/ckeditor5-link that referenced this issue Apr 20, 2020
@tomalec
Other: Update the code comment regarding canceling Ctrl+K key stroke.
ee88aa1 
ckeditor/ckeditor5#6202.

Agreed at ckeditor/ckeditor5-utils#333 (comment)
tomalec added a commit to ckeditor/ckeditor5-paste-from-office that referenced this issue Apr 20, 2020
@tomalec
Other: Remove the complicated innerText.length calculations, required…
572aaa9 
… due to old Edge quirks. ckeditor/ckeditor5#6202.

Agreed at ckeditor/ckeditor5-utils#333 (comment)
tomalec added a commit to ckeditor/ckeditor5-table that referenced this issue Apr 20, 2020
@tomalec
Other: Remove the enigmatic Edge-related code comment. ckeditor/ckedi…
9961e6c 
…tor5#6202.

Agreed at ckeditor/ckeditor5-utils#333 (comment)
tomalec added a commit to ckeditor/ckeditor5-ui that referenced this issue Apr 20, 2020
@tomalec
Other: Remove the Edge-specific assertion for SVG content. ckeditor/c…
9427add 
…keditor5#6202.

Old versions of Edge were sprouting xmlns attributes for inner elements.
Agreed at ckeditor/ckeditor5-utils#333 (comment)
mlewand pushed a commit that referenced this issue May 1, 2020
@tomalec
Other: Remove env.isEdge. Closes #6202.
83c4c90 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
mlewand pushed a commit that referenced this issue May 1, 2020
@tomalec
Other: Remove env.isEdge. Closes #6202.
9d793f7 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
mlewand pushed a commit that referenced this issue May 1, 2020
@tomalec
Other: Remove env.isEdge. Closes #6202.
98a49cb 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
mlewand pushed a commit that referenced this issue May 1, 2020
@tomalec
Other: Remove env.isEdge. Closes #6202.
5102f44 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
mlewand pushed a commit that referenced this issue May 1, 2020
@tomalec
Other: Remove env.isEdge. Closes #6202.
449cbcc 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
mlewand pushed a commit that referenced this issue May 1, 2020
@tomalec
Other: Remove env.isEdge. Closes #6202.
fdeb608 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
mlewand pushed a commit that referenced this issue May 1, 2020
@tomalec
Other: Remove env.isEdge. Closes #6202.
5755688 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
mlewand pushed a commit that referenced this issue May 1, 2020
@tomalec
Other: Remove env.isEdge. Closes #6202.
5d6ef20 
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
mlewand pushed a commit that referenced this issue May 1, 2020
@tomalec
Other: Remove Array.from needed for old Edge engine. #6202
d376a9f 
Use, plain `for ... of  .childNodes`, as agreed at ckeditor/ckeditor5-utils#333 (comment) .
mlewand pushed a commit that referenced this issue May 1, 2020
@tomalec
Other: Remove the Edge-specific assertion for a DOM selection. #6202.
087cb8e 
Agreed at ckeditor/ckeditor5-utils#333 (comment)
mlewand pushed a commit that referenced this issue May 1, 2020
@tomalec
Other: Remove the Edge-specific fallback for image upload. #6202.
48f2192 
Agreed at ckeditor/ckeditor5-utils#333 (comment)
mlewand pushed a commit that referenced this issue May 1, 2020
@tomalec
Other: Update the code comment regarding canceling Ctrl+K key stroke.
dd4359e 
#6202.

Agreed at ckeditor/ckeditor5-utils#333 (comment)
mlewand pushed a commit that referenced this issue May 1, 2020
@tomalec
Other: Remove the complicated innerText.length calculations, required…
e8523de 
… due to old Edge quirks. #6202.

Agreed at ckeditor/ckeditor5-utils#333 (comment)
mlewand pushed a commit that referenced this issue May 1, 2020
@tomalec
Other: Remove the enigmatic Edge-related code comment. #6202.
6597177 
Agreed at ckeditor/ckeditor5-utils#333 (comment)
mlewand pushed a commit that referenced this issue May 1, 2020
@tomalec
Other: Use CSS calc() for --ck-switch-button-translation as it works …
972b5f2 
…in latest Edge. #6202.

Agreed at ckeditor/ckeditor5-utils#333 (comment)
mlewand pushed a commit that referenced this issue May 1, 2020
@tomalec
Other: Remove the Edge-specific assertion for SVG content. #6202.
6711e88 
Old versions of Edge were sprouting xmlns attributes for inner elements.
Agreed at ckeditor/ckeditor5-utils#333 (comment)
mlewand pushed a commit that referenced this issue May 1, 2020
@tomalec
Revert "Other: Remove the Edge-specific assertion for SVG content. #6202
3c49e51 
."

As it was accidentally pushed to the master, instead of i/6202-remove-env.isEdge
This reverts commit 9427addeae19dddcfa711915b5d8fcacdab3c43f.
mlewand pushed a commit that referenced this issue May 1, 2020
@tomalec
Other: Remove the Edge-specific assertion for SVG content. See #6202.
e898e8c 
Old versions of Edge were sprouting xmlns attributes for inner elements.
Agreed at ckeditor/ckeditor5-utils#333 (comment)
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge pull request #333 from ckeditor/i/6202-remove-env.isEdge
bfe923a 
Other: Removed `env.isEdge` as Edge is now detected and treated as Chrome. Closes #6202.

BREAKING CHANGE: `env.isEdge` is no longer available. See #6202.
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge branch i/6202-remove-env.isEdge to master.
446170a 
Internal: Removed mentions on Edge. See #6202.
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge branch i/6202-remove-env.isEdge to master.
bc6048b 
Internal: Removed mentions on Edge. See #6202.
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge branch i/6202-remove-env.isEdge to master.
88fc45c 
Internal: Removed mentions on Edge. See #6202.
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge branch i/6202-remove-env.isEdge to master.
3938a6d 
Internal: Removed mentions on Edge. See #6202.
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge branch i/6202-remove-env.isEdge to master.
fa883c6 
Internal: Removed mentions on Edge. See #6202.
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge branch i/6202-remove-env.isEdge to master.
5d88170 
Internal: Removed mentions on Edge. See #6202.
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge branch i/6202-remove-env.isEdge to master.
6cbd529 
Internal: Removed mentions on Edge. See #6202.
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge branch i/6202-remove-env.isEdge to master.
fa71bdd 
Internal: Removed mentions on Edge. See #6202.
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge branch i/6202-remove-env.isEdge to master.
403c5cb 
Internal: Removed mentions on Edge. See #6202.
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge branch i/6202-remove-env.isEdge to master.
02b507d 
Internal: Removed mentions on Edge. See #6202.
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge branch i/6202-remove-env.isEdge to master.
70302b9 
Internal: Removed mentions on Edge. See #6202.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomalec tomalec

Labels
browser:edge intro Good first ticket. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 31 (v19.0.0)
Development

Successfully merging a pull request may close this issue.

Other: Remove env.isEdge. Closes ckeditor/ckeditor5#6202. ckeditor/ckeditor5-utils
3 participants
@tomalec @Reinmar @jodator