Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS MVP] Rewrite ckeditor5-core #11727

Closed
arkflpc opened this issue May 6, 2022 · 4 comments · Fixed by #12376
Closed

[TS MVP] Rewrite ckeditor5-core #11727

arkflpc opened this issue May 6, 2022 · 4 comments · Fixed by #12376
Assignees
@arkflpc
Labels
domain:ts squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 58 (v35...

Comments

@arkflpc
Copy link
Contributor

arkflpc commented May 6, 2022 •
edited
Loading

Rewrite ckeditor5-core to TypeScript.

Make sure that automated and manual tests run after the rewrite. Tests themselves are out of scope.

This would be the first serious application of EmitterMixing and typing of Emitter done in #11715.

Part of #11708.
@arkflpc arkflpc added squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos". domain:ts and removed type:task This issue reports a chore (non-production change) and other types of "todos". labels May 6, 2022
@arkflpc arkflpc mentioned this issue Jul 5, 2022
Closed
@Reinmar Reinmar mentioned this issue Jul 21, 2022
Closed
@arkflpc
Copy link
Contributor Author

arkflpc commented Aug 5, 2022

Partially done on branch ck/11727-ts-core (https://github.com/ckeditor/ckeditor5/compare/ck/11727-ts-core?expand=1). It doesn't build because ComponentFactory (ckeditor5-ui) is not in TypeScript and I haven't figured out how to force it to compile. index.js is not in TypeScript because we import *.svg files there (I don't know how to approach this).

@ckeditor ckeditor deleted a comment from arkflpc Aug 17, 2022
@Reinmar
Copy link
Member

Reinmar commented Aug 17, 2022

Probably a solution here: https://stackoverflow.com/questions/42631645/webpack-import-typescript-module-both-normally-and-as-raw-string

@niegowski
Copy link
Contributor

It might be connected with raw-loader being deprecated: https://v4.webpack.js.org/loaders/raw-loader/

@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Aug 17, 2022
@arkflpc
Copy link
Contributor Author

arkflpc commented Aug 17, 2022

Solution: https://stackoverflow.com/questions/44717164/unable-to-import-svg-files-in-typescript

@arkflpc arkflpc self-assigned this Aug 22, 2022
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Aug 22, 2022
@arkflpc arkflpc mentioned this issue Aug 31, 2022
Merged
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Aug 31, 2022
arkflpc added a commit that referenced this issue Oct 11, 2022
@arkflpc
Merge pull request #12376 from ckeditor/ck/11726-11727-ts-core-ui
cfd00bf 
Other (ui): Rewrite ckeditor5-ui package to TypeScript. Closes #11726.

Other (core): Rewrite ckeditor5-core package to TypeScript. Closes #11727.

Other (utils): Add types to Config and merge number into PriorityString. Closes #12218.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 11, 2022
@CKEditorBot CKEditorBot added this to the iteration 58 milestone Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkflpc arkflpc

Labels
domain:ts squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 58 (v35.3.0)
Development

Successfully merging a pull request may close this issue.

Rewrite core & ui into TypeScript ckeditor/ckeditor5
4 participants
@Reinmar @niegowski @arkflpc @CKEditorBot