Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] Merge the "number" type into PriorityString #12218

Closed
Tracked by #12027
Reinmar opened this issue Aug 3, 2022 · 0 comments · Fixed by #12376
Closed
Tracked by #12027

[TS] Merge the "number" type into PriorityString #12218

Reinmar opened this issue Aug 3, 2022 · 0 comments · Fixed by #12376
Assignees
@arkflpc
Labels
domain:ts squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 58 (v35...

Comments

@Reinmar
Copy link
Member

Reinmar commented Aug 3, 2022 •
edited
Loading

Followup of: #11708
Part of: #12027

Right now we define a type of e.g. on()'s options.priority param as PriorityString | number.

For me, the number is part of PriorityString. Everywhere where we expect the priority, we also allow a number version of it.

So, the proposal is to:

  • Move number to PriorityString to simplify its use.
  • Keep the current name of this union to avoid increasing visibility of the fact that a number can be used (which should be done only in special cases).
@Reinmar Reinmar added type:task This issue reports a chore (non-production change) and other types of "todos". domain:ts squad:core Issue to be handled by the Core team. labels Aug 3, 2022
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Aug 22, 2022
@arkflpc arkflpc self-assigned this Aug 31, 2022
@arkflpc arkflpc mentioned this issue Aug 31, 2022
Merged
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. labels Aug 31, 2022
arkflpc added a commit that referenced this issue Oct 11, 2022
@arkflpc
Merge pull request #12376 from ckeditor/ck/11726-11727-ts-core-ui
cfd00bf 
Other (ui): Rewrite ckeditor5-ui package to TypeScript. Closes #11726.

Other (core): Rewrite ckeditor5-core package to TypeScript. Closes #11727.

Other (utils): Add types to Config and merge number into PriorityString. Closes #12218.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 11, 2022
@CKEditorBot CKEditorBot added this to the iteration 58 milestone Oct 11, 2022
@Witoso Witoso mentioned this issue Apr 4, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkflpc arkflpc

Labels
domain:ts squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 58 (v35.3.0)
Development

Successfully merging a pull request may close this issue.

Rewrite core & ui into TypeScript ckeditor/ckeditor5
3 participants
@Reinmar @arkflpc @CKEditorBot