Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .d.ts in ckeditor5-build-* packages to include types for loaded plugins #13676

Closed
filipsobol opened this issue Mar 14, 2023 · 0 comments · Fixed by #13678
Closed

Fix .d.ts in ckeditor5-build-* packages to include types for loaded plugins #13676

filipsobol opened this issue Mar 14, 2023 · 0 comments · Fixed by #13678
Assignees
@filipsobol
Labels
squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 61 (v37...

Comments

@filipsobol
Copy link
Member

Currently, the .d.ts files in ckeditor5-build-* packages don't contain types for loaded plugins:

import ClassicEditorBase from '@ckeditor/ckeditor5-editor-classic/src/classiceditor';
export default class ClassicEditor extends ClassicEditorBase {
}

Because there are no imports from any plugins as in the source code, the module augmentation doesn't work properly in consuming projects.
@filipsobol filipsobol added type:bug This issue reports a buggy (incorrect) behavior. squad:core Issue to be handled by the Core team. labels Mar 14, 2023
@filipsobol filipsobol self-assigned this Mar 14, 2023
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Mar 14, 2023
@filipsobol filipsobol mentioned this issue Mar 14, 2023
Merged
pomek added a commit that referenced this issue Mar 14, 2023
@pomek
Merge pull request #13678 from ckeditor/ck/13676-fix-dts-in-build-pac…
fea9b5a 
…kages

Fix (build-*): Typings from the CKEditor 5 builds contain types of loaded plugins. Closes #13676.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Mar 14, 2023
@CKEditorBot CKEditorBot added this to the iteration 61 milestone Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filipsobol filipsobol

Labels
squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 61 (v37.0.0)
Development

Successfully merging a pull request may close this issue.

Fix generated .d.ts in builds to include types of loaded plugins ckeditor/ckeditor5
2 participants
@filipsobol @CKEditorBot