Fix generated .d.ts in builds to include types of loaded plugins
#13678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipsobol
changed the title
.d.ts in builds to include types of loaded plugins
niegowski
approved these changes
Mar 14, 2023
|
I would improve the merge message a bit:
|
pomek
reviewed
Mar 14, 2023
arkflpc
reviewed
Mar 14, 2023
| @@ -32,82 +32,80 @@ import { CloudServices } from '@ckeditor/ckeditor5-cloud-services'; | |||
| */ | |||
| import '../theme/theme.css'; | |||
|
|
|||
| export default class BalloonEditor extends BalloonEditorBase {} | |||
| export default class BalloonEditor extends BalloonEditorBase { | |||
| public static override builtinPlugins = [ | |||
There was a problem hiding this comment.
Does the trick work because builtinPlugins have a tuple type with all plugin types?
There was a problem hiding this comment.
Yes, tuple uses types imported from plugin packages and this gives a TypeScript a chance to load module augmentations with them.
arkflpc
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (build-*): Typings from the CKEditor 5 builds contain types of loaded plugins. Closes #13676.