-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement table captions #3204
Comments
I hope this is the right issue to post this. The currently behaviour with adding a figure is from my side more annoying then good: <figure class="table">
<table>
<!-- ... -->
</table>
</figure> The table itself does not need a figure because it is by itself like a figure it has its own <table>
<caption>Test</caption>
<!-- ... -->
<table> |
@alexander-schranz, we based on this research: https://ckeditor.github.io/editor-recommendations/features/table.html. If you're still unsure, please open a ticket in https://github.com/ckeditor/editor-recommendations/issues. |
Any plans to implement? |
I need table captions for a project I'm working on. Shall I try to implement it and send a PR? You aren't working on it right now, are you? |
@Reinmar The standard of the figure and figcaption tag is sure correctly interpreted, but for a table itself a figure and figcaption in html is not needed as the table itself has a caption tag which should be used instead of wrapping the table in a figure and add a caption. Would really be great to get rid of the figure around the table and use the real table caption instead, maybe this can be configurable to avoid bc breaks. |
@alexander-schranz, I think the rationale for using |
@marcellofuschi thats sentence is definitly true for any textuel content, for the table itself it just doesn't make sense as the table itself is like a figure tag and have its own caption. Wrapping it again into a figure and caption should not be done aslong you don't have more then a table tag inside this figure tag. |
Has there been any further work on this? We are failing accessibility testing because of this. |
Some notes regarding the scope:
|
We've just started working on this 👍 |
Not sure if this is in scope or not but if captions are being added as part of accessibility then scope=row and those attributes are in that same wheelhouse would be beneficial as well. |
Feature (table): Added support for table captions. Closes #3204.
Tables need to be captioned. Most likely, we can implement this just like in the image feature. It'd be also good to extract pieces of shared logic so #1065 is resolved.
Related comments:
If you'd like this feature implemented, please react with 👍 to this post.
The text was updated successfully, but these errors were encountered: