Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To-do list is a focus trap #6535

Closed
mlewand opened this issue Apr 2, 2020 · 2 comments · Fixed by #12445
Closed

To-do list is a focus trap #6535

mlewand opened this issue Apr 2, 2020 · 2 comments · Fixed by #12445
Assignees
@pszczesniak
Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:list squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 57 (v35...

Comments

@mlewand
Copy link
Contributor

mlewand commented Apr 2, 2020

📝 Provide detailed reproduction steps (if any)

  1. Open https://ckeditor.com/docs/ckeditor5/latest/features/todo-lists.html
  2. Focus the editor by placing the selection anywhere in its content
  3. Press the tab key

✔️ Expected result

The focus should go outside of the editor

❌ Actual result

Focus for a brief moment goes to the first input checkbox (you can see it because focus ring blinks for a moment) and goes back to your selection position.

📃 Other details

This is a rather major accessibility issue.

  • Browser: Any
  • OS: Any

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. package:list domain:ui/ux This issue reports a problem related to UI or UX. domain:accessibility This issue reports an accessibility problem. labels Apr 2, 2020
@mlewand mlewand mentioned this issue Apr 2, 2020
Open
@Mgsy Mgsy added this to the nice-to-have milestone Apr 6, 2020
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@Comandeer Comandeer added the squad:features Issue to be handled by the Features team. label May 27, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 29, 2022
@mmotyczynska mmotyczynska self-assigned this Aug 29, 2022
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Aug 30, 2022
@mmotyczynska
Copy link
Contributor

How about setting tabindex to -1 to prevent focusing the checkbox element with tab key? 🤔

@mlewand
Copy link
Contributor Author

mlewand commented Sep 1, 2022

Given that this tab doesn't do anything valuable now it makes perfect sense to drop it from focus list 👍

@mlewand mlewand added the intro Good first ticket. label Sep 1, 2022
@mmotyczynska mmotyczynska removed their assignment Sep 2, 2022
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. labels Sep 2, 2022
@pszczesniak pszczesniak self-assigned this Sep 8, 2022
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Sep 8, 2022
@pszczesniak pszczesniak mentioned this issue Sep 8, 2022
Merged
oleq added a commit that referenced this issue Sep 9, 2022
@oleq
Merge pull request #12445 from ckeditor/ck/6535-to-do-list-is-a-focus…
08e6106 
…-trap

Fix (list): To-do list items should not interrupt the Tab key navigation across the editor content. Closes #6535.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 9, 2022
@CKEditorBot CKEditorBot added this to the iteration 57 milestone Sep 9, 2022
@mlewand mlewand mentioned this issue Sep 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pszczesniak pszczesniak

Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:list squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 57 (v35.2.0)
Development

Successfully merging a pull request may close this issue.

Set tabindex to -1 to prevent focusing the checkbox element with Tab key ckeditor/ckeditor5
7 participants
@Comandeer @pomek @mlewand @pszczesniak @Mgsy @CKEditorBot @mmotyczynska