Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the insert paragraph command for the type around feature #6823

Closed
oleq opened this issue May 14, 2020 · 0 comments · Fixed by #7237
Closed

Implement the insert paragraph command for the type around feature #6823

oleq opened this issue May 14, 2020 · 0 comments · Fixed by #7237
Assignees
@oleq
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:widget squad:magic type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 32 (v19...

Comments

@oleq
Copy link
Member

oleq commented May 14, 2020

Provide a description of the task

It should be based on WidgetTypeAround#_insertParagraph but with additional checks like described in #6794 (comment).
@oleq oleq added type:task This issue reports a chore (non-production change) and other types of "todos". package:widget domain:ui/ux This issue reports a problem related to UI or UX. squad:magic labels May 14, 2020
@oleq oleq mentioned this issue May 14, 2020
Merged
@Reinmar Reinmar added this to the nice-to-have milestone May 18, 2020
@oleq oleq mentioned this issue May 19, 2020
Merged
@oleq oleq self-assigned this May 19, 2020
@oleq oleq modified the milestones: nice-to-have, iteration 32 May 19, 2020
niegowski added a commit that referenced this issue May 21, 2020
@niegowski
Merge pull request #7237 from ckeditor/i/6775
1267018 
Internal (widget): Integrated the `WidgetTypeAround` plugin with the read–only mode. Closes #6775.

Internal (widget): Integrated the `WidgetTypeAround` plugin with the `RestrictedEditingMode` plugin (see #6775).

Feature (paragraph): Implemented the `InsertParagraphCommand` registered as `'insertParagraph'` in the editor. Closes #6823. Closes #7229.

Docs (engine): Improved `Model#insertContent` API documentation (see #6775).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:widget squad:magic type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 32 (v19.1.0)
2 participants
@Reinmar @oleq