#407: Brought the feature allowing users to type in tight spots around block widgets #6794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verflow colliding with the type around feature.
…ure to position its UI.
…preserve its delicate structure.
…y can be used with different alpha values.
…arious dimensions to common custom properties.
…t selected but type around button being hovered on.
…uld insert a paragraph instead of displaying a caption.
…he entire content of a widget (including type around UI).
…d UI in the view.
…erfere with type around UI injected in media widgets.
…TypeAround plugin.
…und.js Co-authored-by: Kuba Niegowski <1232187+niegowski@users.noreply.github.com>
…und.js Co-authored-by: Kuba Niegowski <1232187+niegowski@users.noreply.github.com>
|
Let's give it another round of review. |
niegowski
approved these changes
May 13, 2020
Reinmar
reviewed
May 14, 2020
packages/ckeditor5-widget/src/widgettypearound/widgettypearound.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-widget/src/widgettypearound/widgettypearound.js
Outdated
Show resolved
Hide resolved
Reinmar
reviewed
May 14, 2020
packages/ckeditor5-widget/src/widgettypearound/widgettypearound.js
Outdated
Show resolved
Hide resolved
Reinmar
reviewed
May 14, 2020
packages/ckeditor5-widget/src/widgettypearound/widgettypearound.js
Outdated
Show resolved
Hide resolved
Reinmar
reviewed
May 14, 2020
Reinmar
reviewed
May 14, 2020
packages/ckeditor5-widget/src/widgettypearound/widgettypearound.js
Outdated
Show resolved
Hide resolved
Reinmar
reviewed
May 14, 2020
packages/ckeditor5-widget/src/widgettypearound/widgettypearound.js
Outdated
Show resolved
Hide resolved
Reinmar
reviewed
May 14, 2020
packages/ckeditor5-widget/src/widgettypearound/widgettypearound.js
Outdated
Show resolved
Hide resolved
…d.js Co-authored-by: Piotrek Koszuliński <pkoszulinski@gmail.com>
…d.js Co-authored-by: Piotrek Koszuliński <pkoszulinski@gmail.com>
…ed View#change blocks.
…idgets that have the type around UI injected.
|
Let's have another round of review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (widget): Brought the feature allowing users to type in tight spots around block widgets where web browsers do not allow the caret to be placed (see #407). Closes #6740. Closes #6688. Closes #6689. Closes #6695.
Internal (horizontal-line): Updated the styling of
.ck-horizontal-linefromoverflow: hiddentodisplay: flow-rootto allow the typing around UI inside the widgets (see #407, #6795).Tests (image): Updated various image test to take the widget typing around feature into account (see #407).
Fix (media-mebed): The media widget conversion should not discard widget internals (drag or resize handlers, buttons to insert paragraphs, etc.) injected by other features when converting the URL (see #407).
Feature (theme-lark): Brought styles for the feature allowing users to type in tight spots around block widgets (see #407).
MINOR BREAKING CHANGE: The new
--ck-color-focus-border-coordinatesCSS custom property has been added and the existing--ck-color-focus-borderproperty now uses it internally. If your integration overrides the latter, we recommend you update the former to avoid compatibility issues with various editor UI features.