Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special characters dropdown is cut on mobile #7700

Closed
jodator opened this issue Jul 24, 2020 · 1 comment · Fixed by #8670
Closed

Special characters dropdown is cut on mobile #7700

jodator opened this issue Jul 24, 2020 · 1 comment · Fixed by #8670
Assignees
@magda-chrzescian
Labels
domain:mobile This issues reports a problem related to a mobile environment. domain:ui/ux This issue reports a problem related to UI or UX. package:special-characters squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 39 (v25...

Comments

@jodator
Copy link
Contributor

jodator commented Jul 24, 2020

📝 Provide detailed reproduction steps (if any)

  1. Open special characters dropdown on mobile

✔️ Expected result

I'm able to interact with the special characters feature.

❌ Actual result

📃 Other details

  • Browser: Chrome
  • OS: Android

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@jodator jodator added type:bug This issue reports a buggy (incorrect) behavior. domain:ui/ux This issue reports a problem related to UI or UX. package:special-characters domain:mobile This issues reports a problem related to a mobile environment. labels Jul 24, 2020
@jodator jodator mentioned this issue Jul 24, 2020
Closed
@mlewand
Copy link
Contributor

mlewand commented Jul 27, 2020

@oleq wasn't there already a more generic issue reported for that? #5514 looks similar but the body doesn't have hidden overflow.

@mlewand mlewand added this to the backlog milestone Jul 27, 2020
@oleq oleq mentioned this issue Nov 30, 2020
Closed
@oleq oleq added the squad:core Issue to be handled by the Core team. label Nov 30, 2020
@oleq oleq self-assigned this Dec 14, 2020
@oleq oleq modified the milestones: backlog, iteration 39 Dec 14, 2020
@oleq oleq assigned magda-chrzescian and unassigned oleq Dec 14, 2020
@magda-chrzescian magda-chrzescian mentioned this issue Dec 15, 2020
Merged
@oleq oleq mentioned this issue Dec 16, 2020
Closed
@oleq oleq closed this as completed in #8670 Jan 5, 2021
oleq added a commit that referenced this issue Jan 5, 2021
@oleq
Merge pull request #8670 from ckeditor/i/7700-invisible-dropdown
52ce85b 
Fix (special-characters): The special characters dropdown should always fit into the viewport. Closes #7700. Closes #8669.

Feature (ui): Implemented additional [panel positions](https://ckeditor.com/docs/ckeditor5/latest/api/module_ui_dropdown_dropdownview-DropdownView.html#static-member-defaultPanelPositions) for the `DropdownView` class to address edge cases when the panel is cut due to small screen size (see #7700, #8669).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magda-chrzescian magda-chrzescian

Labels
domain:mobile This issues reports a problem related to a mobile environment. domain:ui/ux This issue reports a problem related to UI or UX. package:special-characters squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 39 (v25.0.0)
Development

Successfully merging a pull request may close this issue.

New positions added to drop down panel positions. ckeditor/ckeditor5
4 participants
@jodator @oleq @mlewand @magda-chrzescian