Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special characters grid exceeds drop-down size on small screen. #8669

Closed
magda-chrzescian opened this issue Dec 15, 2020 · 1 comment · Fixed by #8670
Closed

Special characters grid exceeds drop-down size on small screen. #8669

magda-chrzescian opened this issue Dec 15, 2020 · 1 comment · Fixed by #8670
Assignees
@magda-chrzescian
Labels
domain:mobile This issues reports a problem related to a mobile environment. domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:special-characters squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 39 (v25...

Comments

@magda-chrzescian
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

  1. Visit https://ckeditor.com/docs/ckeditor5/latest/features/special-characters.html with mobile.
  2. Open special character dropdown.

✔️ Expected result

The whole content of the drop-down should be visible inside the panel.

❌ Actual result

The content renders outside of the drop-down panel.

📃 Other details

  • Browser: Chrome
  • OS: Android/Windows

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@magda-chrzescian magda-chrzescian added type:bug This issue reports a buggy (incorrect) behavior. package:special-characters labels Dec 15, 2020
@oleq oleq added intro Good first ticket. domain:mobile This issues reports a problem related to a mobile environment. domain:ui/ux This issue reports a problem related to UI or UX. labels Dec 15, 2020
@oleq oleq added this to the iteration 39 milestone Dec 15, 2020
@oleq oleq added the squad:core Issue to be handled by the Core team. label Dec 15, 2020
@oleq
Copy link
Member

oleq commented Dec 16, 2020

Related #7700.

@magda-chrzescian magda-chrzescian mentioned this issue Dec 16, 2020
Merged
@AnnaTomanek AnnaTomanek mentioned this issue Dec 16, 2020
Closed
magda-chrzescian pushed a commit that referenced this issue Dec 23, 2020
Special characters grid fixed (#8669)
9e2716a
@oleq oleq closed this as completed in #8670 Jan 5, 2021
oleq added a commit that referenced this issue Jan 5, 2021
@oleq
Merge pull request #8670 from ckeditor/i/7700-invisible-dropdown
52ce85b 
Fix (special-characters): The special characters dropdown should always fit into the viewport. Closes #7700. Closes #8669.

Feature (ui): Implemented additional [panel positions](https://ckeditor.com/docs/ckeditor5/latest/api/module_ui_dropdown_dropdownview-DropdownView.html#static-member-defaultPanelPositions) for the `DropdownView` class to address edge cases when the panel is cut due to small screen size (see #7700, #8669).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magda-chrzescian magda-chrzescian

Labels
domain:mobile This issues reports a problem related to a mobile environment. domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:special-characters squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 39 (v25.0.0)
Development

Successfully merging a pull request may close this issue.

New positions added to drop down panel positions. ckeditor/ckeditor5
2 participants
@oleq @magda-chrzescian