-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for setting text part language #8989
Comments
Related: #2008 |
We could simplify configuration by automatically detecting |
Do you mean that if the user types some text in Hebrew or Arabic, it will automatically be laid out right-to-left even if the rest of the editor content is left-to-right? Or that the whole editor content will be either right-to-left or left-to-right based whether the majority of the text is in one of the RTL langs or not? |
I just meant the language code to "dir" mapping. |
I should be able to change a paragraph's direction as needed. it can detect paragraphs direction based on first percentage of text in LTR or RTL language. or simply, a LTR/RTL button that allow me to change text direction as needed. |
There's a question that appeared while working on #9074 whether the default tittle of the default configuration of this dropdown have to be translated automatically. IMO, no. It makes no sense as the entire config is there just for showcase purposes. It makes this feature work before someone configures this plugin. But the plugin needs to be configured anyway as the list of 4 options is just completely arbitrary and will not make any sense in 99% of cases. |
The other question that appeared is the name of this feature: https://github.com/ckeditor/ckeditor5/pull/9074/files#r580836210. I find the current name "language" too vague and thus confusing. Therefore, I'm for something more concrete as "text language". cc @wwalc @AnnaTomanek |
|
Feature (language): Added language dropdown button to support text part language. Closes #8989. Other (utils): Added `language.getLanguageDirection` helper function allowing to determine text direction based on language code. Internal (locale): Language text direction detection moved to the `language` utils module.
Where can we screenshots/screencasts of this in action? https://ckeditor.com/blog/ckeditor-5-v26.0.0-with-extensible-builds-inline-widget-styling-and-annotations-guides/ made me curious to see how the CKEditor 5 implementation compares with the CKEditor 4 one 🤓 |
Hi @wimleers, thanks for your interest 👋 The guide is work in progress, it should be merged tomorrow at the latest. The release blog post is due next Wednesday. The feature itself is available in version 27.0.0. |
📝 Provide a description of the new feature
Add support for setting text part language, similar to CKEditor 4 language feature.
If you'd like to see this feature implemented, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: