Added feature docs for text fragment language. #9301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacekbogdanski
commented
Mar 19, 2021
Comment on lines
67
to
73
| // Optionally, you can also provide text direction information ('ltr' or 'rtl'), | ||
| // however, note that the feature will resolve text direction by itself, so in most | ||
| // cases this option is redundant. | ||
| editor.execute( 'textPartLanguage', { | ||
| languageCode: 'ar', | ||
| textDirection: 'rtl' // Optional text direction. | ||
| } ); |
There was a problem hiding this comment.
Not sure if it makes sense to mention the optional textDirection option.
There was a problem hiding this comment.
I'd say let's drop it, if not for the "most cases". If it has some specific use, we may want to mention the specific use in docs.
AnnaTomanek
approved these changes
Mar 26, 2021
AnnaTomanek
reviewed
Mar 26, 2021
AnnaTomanek
reviewed
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Docs (language): Added feature documentation for text fragment language. Closes #9211.
Additional information
For now, I've just added separate docs for
Languageentry, however, it may not be the best fit, see #9211 (comment)Some links are failing during the build:
I'm not really sure why it happens as the same links in API docs are working correctly - would be glad for some help with that.