Code

[WIP] Migrate to before̬̜input͎#11456

Code

Merged

niegowski merged 155 commits intomasterckeditor/ckeditor5:masterfrom ck/epic/11438-migrate-to-beforeinputckeditor/ckeditor5:ck/epic/11438-migrate-to-beforeinputCopy head branch name to clipboardOct 13, 2022

+4,556-4,494

Commits

Commits on Mar 9, 2022

• Improved InputObserver. Moved DataTransfer from clipboard to engine. Enabled InputObserver by default.

  oleq

  committed
  2878a84

  Copy full SHA for 2878a84

• Updated import paths to DataTransfer in clipboard package.

  oleq

  committed
  7b254e7

  Copy full SHA for 7b254e7

• Added beforeinput manual test.

  oleq

  committed
  a9f2d33

  Copy full SHA for a9f2d33

• Migrated EnterObserver to beforeinput.

  oleq

  committed
  2f32c42

  Copy full SHA for 2f32c42

• Migrated DeleteObserver to beforeinput.

  oleq

  committed
  3a44162

  Copy full SHA for 3a44162

Commits on Mar 10, 2022

• Migrated Delete plugin to beforeinput.

  niegowski

  committed
  f211a0b

  Copy full SHA for f211a0b

• Updated docs for moved DataTransfer.

  niegowski

  committed
  a4f707e

  Copy full SHA for a4f707e

• Renamed InputCommand to InsertTextCommand.

  niegowski

  committed
  62c5fb3

  Copy full SHA for 62c5fb3

• The InsertTextCommand supports selection as an input option.

  niegowski

  committed
  8670724

  Copy full SHA for 8670724

• Migrated Input plugin to beforeinput.

  niegowski

  committed
  b9b8c4d

  Copy full SHA for b9b8c4d

Commits on Mar 11, 2022

• Unified preventDefault() across delete, enter and insertText events (always called in plugins, never in observers).

  oleq

  committed
  d375334

  Copy full SHA for d375334

• Migrated block-quote to beforeinput.

  oleq

  committed
  e6f6dbc

  Copy full SHA for e6f6dbc

• Code refactoring: flattened the input plugin tests structure.

  oleq

  committed
  56f27b6

  Copy full SHA for 56f27b6

• Docs.

  oleq

  committed
  c223068

  Copy full SHA for c223068

• Migrated link to beforeinput.

  oleq

  committed
  b9f02c4

  Copy full SHA for b9f02c4

• Migrated list to beforeinput.

  oleq

  committed
  e94ebeb

  Copy full SHA for e94ebeb

• Migrated media embed to beforeinput.

  oleq

  committed
  61be1c1

  Copy full SHA for 61be1c1

• Migrated restricted-editing to beforeinput.

  oleq

  committed
  cbc055b

  Copy full SHA for cbc055b

• Migrated special characters to beforeinput.

  oleq

  committed
  7584079

  Copy full SHA for 7584079

• Migrated tables to beforeinput.

  oleq

  committed
  e8a5541

  Copy full SHA for e8a5541

• Misc change in tables.

  oleq

  committed
  31aab04

  Copy full SHA for 31aab04

• Migrated misc typing tests to beforeinput.

  oleq

  committed
  beb78c9

  Copy full SHA for beb78c9

• Migrated undo to beforeinput.

  oleq

  committed
  c1e1d2b

  Copy full SHA for c1e1d2b

• Migrated Widget plugin tests to beforeinput.

  oleq

  committed
  064e3d8

  Copy full SHA for 064e3d8

• Updated tests for WTA.

  niegowski

  committed
  f345336

  Copy full SHA for f345336

• Updated tests for WTA.

  niegowski

  committed
  d297a61

  Copy full SHA for d297a61

• Added test.

  niegowski

  committed
  b7eeada

  Copy full SHA for b7eeada

Commits on Mar 14, 2022

• Removed Shift+Delete handling on Windows from DeleteObserver. Handled by ClipboardObserver + DeleteObserver does not act on keydown any longer.

  oleq

  committed
  10ba908

  Copy full SHA for 10ba908

• Cleaning delete event logic.

  niegowski

  committed
  0d0c7c8

  Copy full SHA for 0d0c7c8

• Code cleaning.

  niegowski

  committed
  c584939

  Copy full SHA for c584939

• Added option to disable DeleteObserver.

  niegowski

  committed
  ed272ab

  Copy full SHA for ed272ab

• TODO pruning.

  oleq

  committed
  edbf125

  Copy full SHA for edbf125

Commits on Mar 15, 2022

• Merge branch 'master' into ck/epic/11438-migrate-to-beforeinput

  oleq

  committed
  7d7a7e7

  Copy full SHA for 7d7a7e7

• Enabled inspector in beforeinput manual test.

  oleq

  committed
  422f5ae

  Copy full SHA for 422f5ae

• WIP.

  oleq

  committed
  f107868

  Copy full SHA for f107868

Commits on Apr 11, 2022

• Merged master. Resolved conflicts.

  oleq

  committed
  1a85154

  Copy full SHA for 1a85154

• Tests: Added contenteditable demo to the beforeinput manual test.

  oleq

  committed
  f687650

  Copy full SHA for f687650

• Fixed wrong license headers.

  oleq

  committed
  7a21d57

  Copy full SHA for 7a21d57

• Tests: Enhanced manual test.

  oleq

  committed
  6ed368f

  Copy full SHA for 6ed368f

• Tests: Enhanced manual test.

  oleq

  committed
  b864a23

  Copy full SHA for b864a23

Commits on Apr 12, 2022

• Merge branch 'ck/epic/11438-migrate-to-beforeinput' into ck/11438-beforeinput-ime-research-vol1

  oleq

  committed
  fdfcd26

  Copy full SHA for fdfcd26

• Tests: Enhanced manual test.

  oleq

  committed
  e9da12d

  Copy full SHA for e9da12d

• Merge branch 'ck/epic/11438-migrate-to-beforeinput' into ck/11438-beforeinput-ime-research-vol1

  oleq

  committed
  7f1b18a

  Copy full SHA for 7f1b18a

Commits on Apr 15, 2022

• Trying to split composition handling.

  niegowski

  committed
  1c6cf6d

  Copy full SHA for 1c6cf6d

• Merge branch 'master' into ck/epic/11438-migrate-to-beforeinput

  oleq

  committed
  bae3d20

  Copy full SHA for bae3d20

• Merge branch 'ck/epic/11438-migrate-to-beforeinput' into ck/11438-beforeinput-ime-research-vol1.1

  oleq

  committed
  89528a4

  Copy full SHA for 89528a4

Commits on Apr 19, 2022

• Added PoC of fake caret support.

  niegowski

  committed
  e15b2d4

  Copy full SHA for e15b2d4

Commits on Apr 20, 2022

• Hide widget toolbars during composition so they do not break when the widget element gets hidden via DOM API.

  oleq

  committed
  ba21f4b

  Copy full SHA for ba21f4b

Commits on Apr 21, 2022

• Fixing DOM selection after composition abort.

  niegowski

  committed
  975bfa4

  Copy full SHA for 975bfa4

• Addressed desync between view and DOM in the renderer on compositionend resulting in errors.

  oleq

  committed
  9c2c32f

  Copy full SHA for 9c2c32f

Commits on Apr 25, 2022

• Reverted insertText command isEnabled flag changes.

  niegowski

  committed
  f360f76

  Copy full SHA for f360f76

• Fixed superfluous markToSync for UI and RAW element children.

  niegowski

  committed
  3714243

  Copy full SHA for 3714243

Commits on Apr 26, 2022

• Addressed error thrown when WidgetToolbarRepository is not loaded.

  oleq

  committed
  2b6be89

  Copy full SHA for 2b6be89

Commits on May 9, 2022

• Merge branch 'master' into ck/epic/11438-migrate-to-beforeinput

  oleq

  committed
  f6b51c6

  Copy full SHA for f6b51c6

• Merge branch 'ck/epic/11438-migrate-to-beforeinput' into ck/11438-beforeinput-ime-research-vol1

  oleq

  committed
  3ff4d4d

  Copy full SHA for 3ff4d4d

• Merge branch 'ck/11438-beforeinput-ime-research-vol1' into ck/11438-beforeinput-ime-research-vol1.1

  oleq

  committed
  38382ca

  Copy full SHA for 38382ca

Commits on May 10, 2022

• Restored MutationObserver.

  oleq

  committed
  c0e2a2e

  Copy full SHA for c0e2a2e

Commits on Jun 8, 2022

• Merge branch 'master' into ck/epic/11438-migrate-to-beforeinput

  niegowski

  committed
  fa13181

  Copy full SHA for fa13181

• Merge branch 'ck/epic/11438-migrate-to-beforeinput' into ck/11438-beforeinput-ime-research-vol1

  niegowski

  committed
  9f73cd6

  Copy full SHA for 9f73cd6

• Merge branch 'ck/11438-beforeinput-ime-research-vol1' into ck/11438-beforeinput-ime-research-vol1.1

  niegowski

  committed
  a52fc6e

  Copy full SHA for a52fc6e

Commits on Jun 13, 2022

• Ported a manual test for a raw contenteditable from the Android branch.

  Reinmar

  committed
  a3eb855

  Copy full SHA for a3eb855

Commits on Jun 14, 2022

• Revival of the MutationObserver in the basic form.

  

  niegowski

  authored and

  Reinmar

  committed
  f0b0f9f

  Copy full SHA for f0b0f9f

• Ditched compositionstart/end in favor of isComposing property.

  

  niegowski

  authored and

  Reinmar

  committed
  cae5ea7

  Copy full SHA for cae5ea7

• Applied generic changes from android research branch. Logging hidden behind the global variable/checkboxes.

  niegowski

  committed
  5ebb08d

  Copy full SHA for 5ebb08d

Commits on Jun 21, 2022

• Added logging of DataTransfer content.

  niegowski

  committed
  5a9ae0f

  Copy full SHA for 5a9ae0f

• Fixed DataTransfer logging.

  niegowski

  committed
  bda7c88

  Copy full SHA for bda7c88

Commits on Jun 22, 2022

• Based on our research, keydown on Safari is fired after compositionstart+beforeinput. Hence, deleting content at that stage was too late. The only reliable events are compositionstart and beforeinp…

  Show description for 9b07d25
  Reinmar

  committed
  9b07d25

  Copy full SHA for 9b07d25

• Minor refactor: Moved the logic related to typing to the Input plugin.

  Reinmar

  committed
  2d44da4

  Copy full SHA for 2d44da4

• The compositionend event to the insertText event translation moved to the CompositionObserver.

  niegowski

  committed
  92490ab

  Copy full SHA for 92490ab

Commits on Jun 23, 2022

• Merge branch 'master' into ck/epic/11438-migrate-to-beforeinput

  oleq

  committed
  8fb4cb8

  Copy full SHA for 8fb4cb8

Commits on Jun 24, 2022

• Simplified target position of composed text.

  niegowski

  committed
  9be6372

  Copy full SHA for 9be6372

• Introduced CK_DEBUG_TYPING in place of a window property for logging.

  Show description for 0e5d651
  niegowski

  committed
  0e5d651

  Copy full SHA for 0e5d651

Commits on Jun 29, 2022

• More verbose typing flow logging.

  niegowski

  committed
  aacca1f

  Copy full SHA for aacca1f

Commits on Jul 1, 2022

• Merge branch 'master' into ck/epic/11438-migrate-to-beforeinput

  Show description for 9fba995
  niegowski

  committed
  9fba995

  Copy full SHA for 9fba995

• Merge branch 'ck/epic/11438-migrate-to-beforeinput' into ck/11438-beforeinput-ime-research-vol1.1

  niegowski

  committed
  fa87543

  Copy full SHA for fa87543

• Added note about a debug flag in the manual test.

  niegowski

  committed
  2757f14

  Copy full SHA for 2757f14

• Cleaned up the test description.

  Reinmar

  committed
  9232741

  Copy full SHA for 9232741

Commits on Jul 4, 2022

• Adding tests.

  niegowski

  committed
  4c557fc

  Copy full SHA for 4c557fc

Commits on Jul 5, 2022

• Cleaning of the new MutationObserver and added tests for new role.

  niegowski

  committed
  45c2ec1

  Copy full SHA for 45c2ec1

Commits on Jul 6, 2022

• Added tests for InsertTextObserver. Fixed the isEnabled flag handling of InsertTextObserver.

  niegowski

  committed
  d39f9c1

  Copy full SHA for d39f9c1

• Added tests for input plugin composition start handling.

  niegowski

  committed
  7ae0c7a

  Copy full SHA for 7ae0c7a

• Added tests for WTA. Fixed the isEnabled flag handling of WTA.

  niegowski

  committed
  2a2e724

  Copy full SHA for 2a2e724

Commits on Jul 11, 2022

• Fixed keydown handling on links.

  niegowski

  committed
  18c8d63

  Copy full SHA for 18c8d63

• Prototyping a TypingSimulator.

  niegowski

  committed
  34c4db1

  Copy full SHA for 34c4db1

Commits on Jul 12, 2022

• PoC of TypingSimulator.

  niegowski

  committed
  908cdee

  Copy full SHA for 908cdee

Commits on Jul 13, 2022

• Removed TypingSimulator.

  niegowski

  committed
  7231e1c

  Copy full SHA for 7231e1c

• Fixed failing tests (invalid event mock).

  niegowski

  committed
  fd3bea4

  Copy full SHA for fd3bea4

Commits on Jul 18, 2022

• Corrected MutationObserve's documentation.

  Reinmar

  committed
  e4bb6ac

  Copy full SHA for e4bb6ac

• Minor wording corrections.

  Reinmar

  committed
  afaeca6

  Copy full SHA for afaeca6

Commits on Jul 19, 2022

• Removed not needed code.

  niegowski

  committed
  bad982b

  Copy full SHA for bad982b

Commits on Jul 28, 2022

• Trying to workaround composition on Android.

  niegowski

  committed
  56f4f41

  Copy full SHA for 56f4f41

Commits on Jul 29, 2022

• Merge remote-tracking branch 'origin/master' into ck/epic/11438-migrate-to-beforeinput

  arkflpc

  committed
  4ffd85b

  Copy full SHA for 4ffd85b

Commits on Aug 1, 2022

• Merge pull request #12024 from ckeditor/ck/11438-beforeinput-ime-research-vol1.1

  Show description for 3035122
  Reinmar

  authored
  3035122

  Copy full SHA for 3035122

Commits on Aug 8, 2022

• Merge commit 'f2e7b491e919353c48999aa3afa2d0b7e861bb90' into ck/epic/11438-migrate-to-beforeinput

  niegowski

  committed
  6ed2dd9

  Copy full SHA for 6ed2dd9

• Merge branch 'master' into ck/epic/11438-migrate-to-beforeinput

  niegowski

  committed
  7b55c64

  Copy full SHA for 7b55c64

• Fix after merge.

  niegowski

  committed
  1fccb60

  Copy full SHA for 1fccb60

• Merge commit '6ed2dd9a65d736a7bf1c9e4b56b8352464e0344c' into ck/11438-beforeinput-ime-research-vol1.1-android

  niegowski

  committed
  e16d9c8

  Copy full SHA for e16d9c8

• Merge branch 'ck/epic/11438-migrate-to-beforeinput' into ck/11438-beforeinput-ime-research-vol1.1-android

  niegowski

  committed
  8000f16

  Copy full SHA for 8000f16

• Fix after merge.

  niegowski

  committed
  9a02e6c

  Copy full SHA for 9a02e6c

Commits on Aug 9, 2022

• Experimenting with IME on Android.

  niegowski

  committed
  71a38bf

  Copy full SHA for 71a38bf

Commits on Aug 11, 2022

• Experimenting with not re-rendering while composing on Android until structure of the DOM requires changes (except text nodes).

  niegowski

  committed
  fa216e5

  Copy full SHA for fa216e5

Commits on Aug 17, 2022

• Updating text nodes instead of replacing them while renderer is updating children of some element.

  niegowski

  committed
  16e66a0

  Copy full SHA for 16e66a0

• Trying to postpone text update while composing.

  niegowski

  committed
  bc2c5b9

  Copy full SHA for bc2c5b9

Commits on Aug 18, 2022

• Replacing text node content instead of replacing the whole node.

  niegowski

  committed
  1857833

  Copy full SHA for 1857833

• Removed unnecessary forceRender call. It's triggered by the MutationObserver.

  niegowski

  committed
  4d6a6ce

  Copy full SHA for 4d6a6ce

Commits on Aug 19, 2022

• WiP.

  niegowski

  committed
  a562f4b

  Copy full SHA for a562f4b

• WiP.

  niegowski

  committed
  0f9abfa

  Copy full SHA for 0f9abfa

• WiP.

  niegowski

  committed
  cd9c409

  Copy full SHA for cd9c409

• Disabled inline filler on Android after/before an inline element. The beforeinput events are not default prevented while composing.

  niegowski

  committed
  2fb1daf

  Copy full SHA for 2fb1daf

• Added more logs.

  niegowski

  committed
  3f2a8b0

  Copy full SHA for 3f2a8b0

Commits on Sep 7, 2022

• Merge branch 'master' into ck/epic/11438-migrate-to-beforeinput

  Show description for 0d6f7b8
  niegowski

  committed
  0d6f7b8

  Copy full SHA for 0d6f7b8

• Merge branch 'ck/epic/11438-migrate-to-beforeinput' into ck/11438-beforeinput-ime-research-vol1.1-android

  niegowski

  committed
  9a280d5

  Copy full SHA for 9a280d5

• Trimming text composed on Android to cover only inserted/removed data.

  niegowski

  committed
  f8131b3

  Copy full SHA for f8131b3

• Attempt to solve issue with insertCompositionText with newline character at the end.

  niegowski

  committed
  17162e1

  Copy full SHA for 17162e1

• The model delete content should not be triggered on composition start but on the first keydown with keyCode 229.

  niegowski

  committed
  1f74b50

  Copy full SHA for 1f74b50

Commits on Sep 9, 2022

• Experiments with composition in the fake selection container on Android SwiftKey keyboard.

  niegowski

  committed
  9044dea

  Copy full SHA for 9044dea

Commits on Sep 13, 2022

• Renderer should not leave DOM partly updated.

  Show description for 9ede412
  niegowski

  committed
  9ede412

  Copy full SHA for 9ede412

Commits on Sep 14, 2022

• Fixing delete content on backspace on Android.

  niegowski

  committed
  0b00bc6

  Copy full SHA for 0b00bc6

Commits on Sep 15, 2022

• Using input buffer while deleting non collapsed selection on composition start (singe undo step).

  niegowski

  committed
  99bd926

  Copy full SHA for 99bd926

• Removed old selection fixing on Android after delete.

  niegowski

  committed
  f49a719

  Copy full SHA for f49a719

• Fixed non collapsed delete handling on Android.

  niegowski

  committed
  a699fd9

  Copy full SHA for a699fd9

Commits on Sep 16, 2022

• Added more logging.

  niegowski

  committed
  6e1670b

  Copy full SHA for 6e1670b

Commits on Sep 19, 2022

• Fix (input). Fixes deleting all content in Chrome. Closes 11904.

  arkflpc

  committed
  b9c4008

  Copy full SHA for b9c4008

• Delete in Chrome workaround: don't stop the keyup event

  arkflpc

  committed
  2812692

  Copy full SHA for 2812692

• Add TODO about Chromium bug

  arkflpc

  committed
  b630ccb

  Copy full SHA for b630ccb

• Merge pull request #12474 from ckeditor/ck/11904

  Show description for f521ff3
  niegowski

  authored
  f521ff3

  Copy full SHA for f521ff3

• Merge branch 'master' into ck/epic/11438-migrate-to-beforeinput

  niegowski

  committed
  a359c7a

  Copy full SHA for a359c7a

• Merge branch 'ck/epic/11438-migrate-to-beforeinput' into ck/11438-beforeinput-ime-research-vol1.1-android

  niegowski

  committed
  fc99ff1

  Copy full SHA for fc99ff1

• Fixed test after merge.

  niegowski

  committed
  54f7bfb

  Copy full SHA for 54f7bfb

• Merge branch 'ck/epic/11438-migrate-to-beforeinput' into ck/11438-beforeinput-ime-research-vol1.1-android

  niegowski

  committed
  9dc8b51

  Copy full SHA for 9dc8b51

• Added tests.

  niegowski

  committed
  d7d14c6

  Copy full SHA for d7d14c6

Commits on Sep 20, 2022

• Adding tests.

  niegowski

  committed
  8b883e2

  Copy full SHA for 8b883e2

Commits on Sep 21, 2022

• Adding tests.

  niegowski

  committed
  e303ae2

  Copy full SHA for e303ae2

Commits on Sep 22, 2022

• Added tests.

  niegowski

  committed
  13b8d0e

  Copy full SHA for 13b8d0e

Commits on Sep 28, 2022

• Review fixes.

  niegowski

  committed
  96ca498

  Copy full SHA for 96ca498

Commits on Sep 30, 2022

• Updated code comments.

  niegowski

  committed
  2b9e30f

  Copy full SHA for 2b9e30f

Commits on Oct 6, 2022

• Merge branch 'master' into ck/epic/11438-migrate-to-beforeinput

  Show description for 3a40ca2
  niegowski

  committed
  3a40ca2

  Copy full SHA for 3a40ca2

• Merge branch 'ck/epic/11438-migrate-to-beforeinput' into ck/11438-beforeinput-ime-research-vol1.1-android

  niegowski

  committed
  9292593

  Copy full SHA for 9292593

Commits on Oct 10, 2022

• Fixed selection updating after fake selection.

  niegowski

  committed
  595a7dd

  Copy full SHA for 595a7dd

• Normalizing DOM children if there are text nodes next to one another.

  niegowski

  committed
  39c65f7

  Copy full SHA for 39c65f7

Commits on Oct 11, 2022

• Removed console.log().

  niegowski

  committed
  09b29c3

  Copy full SHA for 09b29c3

• Added test for 100cc.

  niegowski

  committed
  1f3c8d0

  Copy full SHA for 1f3c8d0

• Merge branch 'master' into ck/epic/11438-migrate-to-beforeinput

  niegowski

  committed
  79018da

  Copy full SHA for 79018da

• Merge branch 'ck/epic/11438-migrate-to-beforeinput' into ck/11438-beforeinput-ime-research-vol1.1-android

  niegowski

  committed
  fd695a3

  Copy full SHA for fd695a3

• Fixed domPositionToView() for cases when position is between inline filler and an inline element (br).

  niegowski

  committed
  17c7c49

  Copy full SHA for 17c7c49

• Placeholder should be hidden while composing.

  niegowski

  committed
  2494349

  Copy full SHA for 2494349

Commits on Oct 12, 2022

• Merge pull request #12446 from ckeditor/ck/11438-beforeinput-ime-research-vol1.1-android

  Show description for eb7f60d
  niegowski

  authored
  eb7f60d

  Copy full SHA for eb7f60d

• Added tests.

  niegowski

  committed
  f8d4f32

  Copy full SHA for f8d4f32

• Merge branch 'master' into ck/epic/11438-migrate-to-beforeinput

  niegowski

  committed
  0d5fcf7

  Copy full SHA for 0d5fcf7

Commits on Oct 13, 2022

• Merge pull request #12639 from ckeditor/ck/12389

  Show description for 885dc2e
  arkflpc

  authored
  885dc2e

  Copy full SHA for 885dc2e

• Merge branch 'master' into ck/epic/11438-migrate-to-beforeinput

  Show description for a3e6a57
  niegowski

  committed
  a3e6a57

  Copy full SHA for a3e6a57

• Change array style

  arkflpc

  committed
  5fe4283

  Copy full SHA for 5fe4283

• After review.

  niegowski

  committed
  65c1dc9

  Copy full SHA for 65c1dc9

• Merge remote-tracking branch 'origin/ck/epic/11438-migrate-to-beforeinput' into ck/epic/11438-migrate-to-beforeinput

  niegowski

  committed
  044070d

  Copy full SHA for 044070d

• Merge branch 'master' into ck/epic/11438-migrate-to-beforeinput

  niegowski

  committed
  2c08378

  Copy full SHA for 2c08378