Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Migrate to before̬̜input͎ #11456

Merged
merged 155 commits into from
Oct 13, 2022
Merged

[WIP] Migrate to before̬̜input͎ #11456

merged 155 commits into from
Oct 13, 2022

Conversation

oleq
Copy link
Member

@oleq oleq commented Mar 11, 2022 •
edited by niegowski
Loading

Suggested merge commit message (convention)

Feature (engine, enter, typing): Typing and text composition (IME) support refactored to use beforeInput DOM events instead of DOM mutations and keystrokes. Closes #11438.

Other (typing): Introduced a new insertText event mapped from a subset of beforeInput events.

Other (typing): The delete event is now mapped from a subset of beforeInput events.

Other (enter): The enter event is now mapped from a subset of beforeInput events.

Fix (engine): Fixed conversion of the non-collapsed selection anchored between <br> elements (in Safari).

MINOR BREAKING CHANGE (clipboard): The DataTransfer class was moved to the engine package.

MINOR BREAKING CHANGE: The input command is now deprecated, you should use insertText command instead.

oleq and others added 30 commits March 9, 2022 14:43
@oleq
Improved InputObserver. Moved DataTransfer from clipboard to engine. …
2878a84 
…Enabled InputObserver by default.
@oleq
Updated import paths to DataTransfer in clipboard package.
7b254e7
@oleq
Added beforeinput manual test.
a9f2d33
@oleq
Migrated EnterObserver to beforeinput.
2f32c42
@oleq
Migrated DeleteObserver to beforeinput.
3a44162
@niegowski
Migrated Delete plugin to beforeinput.
f211a0b
@niegowski
Updated docs for moved DataTransfer.
a4f707e
@niegowski
Renamed InputCommand to InsertTextCommand.
62c5fb3
@niegowski
The InsertTextCommand supports selection as an input option.
8670724
@niegowski
Migrated Input plugin to beforeinput.
b9b8c4d
@oleq
Unified preventDefault() across delete, enter and insertText events (…
d375334 
…always called in plugins, never in observers).
@oleq
Migrated block-quote to beforeinput.
e6f6dbc
@oleq
Code refactoring: flattened the input plugin tests structure.
56f27b6
@oleq
Docs.
c223068
@oleq
Migrated link to beforeinput.
b9f02c4
@oleq
Migrated list to beforeinput.
e94ebeb
@oleq
Migrated media embed to beforeinput.
61be1c1
@oleq
Migrated restricted-editing to beforeinput.
cbc055b
@oleq
Migrated special characters to beforeinput.
7584079
@oleq
Migrated tables to beforeinput.
e8a5541
@oleq
Misc change in tables.
31aab04
@oleq
Migrated misc typing tests to beforeinput.
beb78c9
@oleq
Migrated undo to beforeinput.
c1e1d2b
@oleq
Migrated Widget plugin tests to beforeinput.
064e3d8
@niegowski
Updated tests for WTA.
f345336
@niegowski
Updated tests for WTA.
d297a61
@niegowski
Added test.
b7eeada
@oleq
Removed Shift+Delete handling on Windows from DeleteObserver. Handled…
10ba908 
… by ClipboardObserver + DeleteObserver does not act on keydown any longer.
@niegowski
Cleaning delete event logic.
0d0c7c8
@niegowski
Code cleaning.
c584939
@Reinmar Reinmar mentioned this pull request Sep 30, 2022
Closed
niegowski and others added 15 commits September 30, 2022 18:10
@niegowski
Updated code comments.
2b9e30f
@niegowski
Merge branch 'master' into ck/epic/11438-migrate-to-beforeinput
3a40ca2 
# Conflicts:
#	packages/ckeditor5-enter/package.json
#	packages/ckeditor5-typing/package.json
@niegowski
Merge branch 'ck/epic/11438-migrate-to-beforeinput' into ck/11438-bef…
9292593 
…oreinput-ime-research-vol1.1-android
@niegowski
Fixed selection updating after fake selection.
595a7dd
@niegowski
Normalizing DOM children if there are text nodes next to one another.
39c65f7
@niegowski
Removed console.log().
09b29c3
@niegowski
Added test for 100cc.
1f3c8d0
@niegowski
Merge branch 'master' into ck/epic/11438-migrate-to-beforeinput
79018da
@niegowski
Merge branch 'ck/epic/11438-migrate-to-beforeinput' into ck/11438-bef…
fd695a3 
…oreinput-ime-research-vol1.1-android
@niegowski
Fixed domPositionToView() for cases when position is between inline f…
17c7c49 
…iller and an inline element (br).
@niegowski
Placeholder should be hidden while composing.
2494349
@niegowski
Merge pull request #12446 from ckeditor/ck/11438-beforeinput-ime-rese…
eb7f60d 
…arch-vol1.1-android

Internal (engine, typing, enter, widget): Support for IME on Android. Closes #12058.
@niegowski
Added tests.
f8d4f32
@niegowski
Merge branch 'master' into ck/epic/11438-migrate-to-beforeinput
0d5fcf7
@arkflpc
Merge pull request #12639 from ckeditor/ck/12389
885dc2e 
Fix (engine): The placeholder should not be visible while composing. Closes #12389.
@niegowski niegowski marked this pull request as ready for review October 13, 2022 09:39
niegowski and others added 2 commits October 13, 2022 12:16
@niegowski
Merge branch 'master' into ck/epic/11438-migrate-to-beforeinput
a3e6a57 
# Conflicts:
#	packages/ckeditor5-engine/src/view/observer/mutationobserver.ts
#	packages/ckeditor5-engine/src/view/renderer.ts
@arkflpc
Change array style
5fe4283
@arkflpc arkflpc self-requested a review October 13, 2022 10:31
arkflpc
arkflpc requested changes Oct 13, 2022
View reviewed changes
packages/ckeditor5-engine/src/view/datatransfer.ts Outdated Show resolved Hide resolved
packages/ckeditor5-engine/src/view/view.ts Outdated Show resolved Hide resolved
packages/ckeditor5-engine/tests/view/view/view.js Outdated Show resolved Hide resolved
packages/ckeditor5-typing/tests/manual/beforeinput.md Show resolved Hide resolved
@niegowski niegowski merged commit a930fef into master Oct 13, 2022
@niegowski niegowski deleted the ck/epic/11438-migrate-to-beforeinput branch October 13, 2022 11:59
@pomek pomek mentioned this pull request Oct 18, 2022
Closed
@niegowski
Copy link
Contributor

MINOR BREAKING CHANGE: The input command is now deprecated, you should use insertText command instead.

To give some more background. This PR is changing the input flow, so the editor is now using the beforeInput events instead of DOM mutation-based input. The previous command (input) is still available as an alias and the same options should be accepted by both commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkflpc arkflpc arkflpc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to beforeInput vol 2
7 participants
@oleq @dufipl @Mgsy @FilipTokarski @Reinmar @niegowski @arkflpc