PoC of new installation method #15331
Conversation
…w-installation-method
| // To check if component is loaded more than once. | ||
| import '@ckeditor/ckeditor5-utils/src/version'; | ||
|
|
There was a problem hiding this comment.
I removed this side-effect import because in new build there will be no access to the /src folder, so it won't work as-is.
I'm not sure why it's here, and I couldn't find a ticket related to this commit. Version should already be checked by the utils package, so do we need this?
I also plan to add a static version property to the Plugin and Editor classes so that they can be compared to each other to specifically detect which plugins are causing the ckeditor-duplicated-modules error, so the highlighted check may not be needed.
| @@ -2,3 +2,83 @@ | |||
| * Copyright (c) 2003-2023, CKSource Holding sp. z o.o. All rights reserved. | |||
| * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license | |||
| */ | |||
|
|
|||
| /* TODO: Order */ | |||
There was a problem hiding this comment.
The order of the imports is important here. For example, with the current order, the "Powered by CKEditor" banner isn't positioned correctly if there's content after the editor.
I need to spend some more time to find the optimal order, but maybe @oleq can point out any obvious problems with this order?
There was a problem hiding this comment.
The order of the imports is important here. For example, with the current order, the "Powered by CKEditor" banner isn't positioned correctly if there's content after the editor.
Can you post a screenshot of that? It should not matter because "Powered by" banner is positioned absolutely (like any other balloon in the UI) and lives far aways from the editing root element in DOM (in the "body" collection).
| @@ -38,7 +38,6 @@ import { | |||
| } from '@ckeditor/ckeditor5-utils'; | |||
|
|
|||
| import '../../theme/components/dropdown/toolbardropdown.css'; | |||
| import '../../theme/components/dropdown/listdropdown.css'; | |||
There was a problem hiding this comment.
We no longer need to import the empty CSS files, because the entire theme-lark is built as one CSS file. This increases the base CSS size by about 10kB gzipped, but we no longer need CKEditor specific plugins for webpack or Vite.
| compilerOptions: { | ||
| declarationDir: `${ cwd }/dist/types`, | ||
| declaration: true, | ||
| declarationMap: false, // TODO |
There was a problem hiding this comment.
This option is probably not needed, but if we have problems with VSCode or other editors navigating to .d.ts files instead of the source .ts files, then we need to enable this option during development.
| terser( { | ||
| format: { | ||
| // Remove all comments except third-party licenses and the license banner from above (starting with `!`). | ||
| comments: ( node, comment ) => /@license/.test( comment.value ) && ( /^!/.test( comment.value ) || !/CKSource/.test( comment.value ) ) |
There was a problem hiding this comment.
I'm not a lawyer, but I'm guessing that we need to keep licenses of 3rd party libraries even in minified CDN builds. Is it safe to assume that these license comments will contain @license?
|
What are the reasons behind the TS bump? |
I updated TS to the latest version to be able to use ckeditor5/tsconfig.kowalski.json Line 20 in d548fed More information: https://www.typescriptlang.org/tsconfig#moduleResolution |
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| // Importing types for this package is problematic, so it's omitted. | |||
| // @ts-ignore | |||
| import TurndownService from 'turndown'; | |||
| import TurndownService from 'turndown/lib/turndown.browser.es'; | |||
There was a problem hiding this comment.
The default turndown bundle contains require('jsdom'), so I updated the import to use the browser version instead.
| sourcemap: sourceMap, | ||
| banner | ||
| }, | ||
| external, |
There was a problem hiding this comment.
Change to external: id => external.some( name => id.startsWith( name ) )
Suggested merge commit message (convention)
Type: Message. Closes #000.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.