-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4715: Autolink feature #7478
4715: Autolink feature #7478
Conversation
Hey, @ckeditor/qa-team - there's a new feature to check - cc @Reinmar since Olek is out could you take a quick look at the feature guide: |
Test case:
The same result I've got in the autolink MT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature looks good. Unfortunately, it replaces too many words.
From CI:
|
I've updated the commit/merge message. |
Co-authored-by: Kamil Piechaczek <pomek@users.noreply.github.com>
@pomek I think I've addressed all the issues. |
This comment has been minimized.
This comment has been minimized.
I think that the selection remains after
In that case it works OK. Do you recall a bug with rendering selection after shift+enter? I think that I saw something like that. |
True, now I see that the selection doesn't change - it stays after |
@pomek two more things to add. I've forgot about disabling this. |
@pomek OK I've fixed the issues with disabling |
This comment has been minimized.
This comment has been minimized.
I've tested it in various browsers and the feature looks good 👍 |
# Conflicts: # packages/ckeditor5-link/package.json
is this feature released with |
Suggested merge commit message (convention)
Feature (link): Added the
AutoLink
feature which replaces a plain text with a link if typed or pasted content is the link. Closes #4715.Additional information