Plugin collection will allow to require plugin by name when it is provided in config.plugins or if it was already loaded.
#8632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…il if required plugin by name is not found.
…in has string requires.
pomek
reviewed
Dec 11, 2020
| @@ -18,9 +18,12 @@ import CloudServicesUploadAdapter from './cloudservicesuploadadapter'; | |||
| * | |||
| * This is a "glue" plugin which enables: | |||
| * | |||
| * * {@link module:easy-image/cloudservicesuploadadapter~CloudServicesUploadAdapter}. | |||
| * | |||
| * This plugin requires plugin to be present in the editor configuration: | |||
There was a problem hiding this comment.
WDYT about @dependency annotation that could be rendered somehow by our documentation tool?
/**
* ...
* @dependency {module:image/image~Image}
* @dependency {module:image/imageupload~ImageUpload}
* ...
*/I am pretty sure that the dependency list mentioned in the API docs will be missed. As for now, it's ok but the mechanism could be improved in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Plugin collection will allow to require plugin by name when it is provided in
config.pluginsor if it was already loaded. Closes #2907.Additional information