PluginCollection logic might be improved #8634
Labels
domain:dx
This issue reports a developer experience problem or possible improvement.
domain:extending-builds
package:core
type:refactor
This issue requires or describes a code refactoring.
type:task
This issue reports a chore (non-production change) and other types of "todos".
Milestone
Provide a description of the task
The plugin collection does multiple checks for required plugins but its logic is mangled.
In #8632 I've pushed some improvements in "soft" requirements checking but this whole logic can be changed to two-way pass:
plugins
and plugins to load fromrequires
property.This is inspired by the idea of having all the changes in the downcast dispatcher (differ) before running conversion (cc @Reinmar ).
Right now, the logic for which plugin is loaded and which are available is a bit mangled. This will allow checking all dependencies (hard or soft), event if deeply nested (like:
ArticlePluginSet
->Essentials
->Enter
, etc) before trying to load the editor.This would also allow to properly order plugins (ie like described in #2907.
Additionally, the errors could describe which plugins are missing and which plugins were requiring it. ATM the errors either say which plugins are missing or which soft requirement was not met (on the first error only).
The thrown errors might need to be updated as well: #8680.
The text was updated successfully, but these errors were encountered: