Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cpptools disabled check to be case-insensitive #382

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

appden
Copy link
Contributor

@appden appden commented Sep 29, 2022

The casing for C_Cpp.intelliSenseEngine was recently changed in microsoft/vscode-cpptools#9862 to be lowercase, but this extension will complain every 5 seconds unless the configuration value is strictly the capitalized "Disabled". This uses toLowerCase() to still support the legacy capitalized value just like the cpptools extension.

@sam-mccall sam-mccall merged commit 3ba1c23 into clangd:master Sep 30, 2022
@sam-mccall
Copy link
Member

Thanks!

@appden appden deleted the fix-cpptools-check branch September 30, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants