change to camelCase for Default, Enabled, Disabled #9862
Conversation
There was a problem hiding this comment.
A couple of 'default' values in the package.json need to be updated.
When doing string comparisons, you will need to lowercase the value before checking against the new lowercase value because some people might still have a PascalCase value for the setting. I didn't mark all the places that need to be updated.
| @@ -158,7 +158,7 @@ export class CustomConfigurationProviderCollection { | |||
| } | |||
|
|
|||
| public add(provider: CustomConfigurationProvider, version: Version): boolean { | |||
| if (new CppSettings(ext.getActiveClient().RootUri).intelliSenseEngine === "Disabled") { | |||
| if (new CppSettings(ext.getActiveClient().RootUri).intelliSenseEngine === "disabled") { | |||
There was a problem hiding this comment.
Alternatively, you could lower case these in the getters in settings.ts so they always return lower case strings. Then all comparisons between settings originating from these getters would not need any conversions. That would seem simpler, as we'd need to deal with potentially different casing in much fewer places (no other places?).
Also, for setters that are simply enabled/disabled, it would be most efficient if they were converted into bools by the getters in settings.ts, so could thereafter be evaluated as bools instead of needing to do any more expensive string conversions/comparisons.
|
@bobbrow Can you re-review/approve this? It says you're requesting changes still. |
|
I removed my block on this PR, but the 2 package.json |
…osoft/vscode-cpptools into browntarik/changePascalCase
| @@ -2158,11 +2158,11 @@ | |||
| "C_Cpp.intelliSenseEngine": { | |||
| "type": "string", | |||
| "enum": [ | |||
| "Default", | |||
| "default", | |||
| "Tag Parser", | |||
There was a problem hiding this comment.
What about the "Tag Parser" enum? That seems inconsistent now.
There was a problem hiding this comment.
should it be "tagParser"? The C++ side might need updating.
| "Default", | ||
| "Disabled" | ||
| "default", | ||
| "disabled" | ||
| ], | ||
| "markdownEnumDescriptions": [ | ||
| "%c_cpp.configuration.formatting.clangFormat.markdownDescription%", | ||
| "%c_cpp.configuration.formatting.vcFormat.markdownDescription%", | ||
| "%c_cpp.configuration.formatting.Default.markdownDescription%", |
There was a problem hiding this comment.
Maybe these string for the enum descriptions should be updated too?
change casing to reflect changes made in adding the case sensitive file support setting