-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support API usage when clangd is disabled or failed to initialize properly #728
Conversation
The code is reorganized slightly so that in the cases where the client would be null, we don't create a ClangdContext object in the first place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This looks a lot neater than #727, I've made one minor suggestion around a static factory function.
There are still a couple of non-null assertions which I addressed in #727. These could be picked up in a subsequent PR.
Line 123 in c7c91e6
let p = config.get<string>('path')!; vscode-clangd/src/clangd-context.ts
Line 123 in c7c91e6
let items = (Array.isArray(list) ? list : list!.items).map(item => {
Thanks!
I went ahead and fixed these. |
Thanks for adding those changes, looks great. |
- The disposables passed in to install.activate() were not saved for cleanup - config.get() is not async
- The disposables passed in to install.activate() were not saved for cleanup - config.get() is not async
- The disposables passed in to install.activate() were not saved for cleanup - config.get() is not async
Fixes #721