fix(help): Fix yet another --help long help edge case (#4712)

clap-rs · Feb 15, 2023 · 8c92ef6 · 8c92ef6
1 parent fb9435d
commit 8c92ef6
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/src/builder/command.rs b/src/builder/command.rs
@@ -4597,9 +4597,10 @@ impl Command {
                 && (v.get_long_help().is_some()
                     || v.is_hide_long_help_set()
                     || v.is_hide_short_help_set()
-                    || v.get_possible_values()
-                        .iter()
-                        .any(PossibleValue::should_show_help))
+                    || (!v.is_hide_possible_values_set()
+                        && v.get_possible_values()
+                            .iter()
+                            .any(PossibleValue::should_show_help)))
         };
 
         // Subcommands aren't checked because we prefer short help for them, deferring to

diff --git a/tests/builder/help.rs b/tests/builder/help.rs
@@ -676,6 +676,29 @@ Options:
     utils::assert_output(app, "ctest --help", POS_VALS_HELP, false);
 }
 
+#[test]
+fn hidden_possible_vals() {
+    static POS_VALS_HELP: &str = "\
+Usage: ctest [pos]
+
+Arguments:
+  [pos]  
+
+Options:
+  -h, --help  Print help
+";
+    let app = Command::new("ctest").arg(
+        Arg::new("pos")
+            .hide_possible_values(true)
+            .value_parser([
+                PossibleValue::new("fast"),
+                PossibleValue::new("slow").help("not as fast"),
+            ])
+            .action(ArgAction::Set),
+    );
+    utils::assert_output(app, "ctest --help", POS_VALS_HELP, false);
+}
+
 #[test]
 #[cfg(feature = "wrap_help")]
 fn issue_626_panic() {