Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(help): Don't accidentally show long help with --help when it isn't intended. #4712

Merged

Conversation

not-my-profile
Copy link
Contributor

@not-my-profile not-my-profile commented Feb 15, 2023

Similar to #4710, we are showing long help because of possible values despite them being hidden.

@epage epage changed the title fix(help): Fix yet another --help long help edge case fix(help): Don't accidentally show long help with --help when it isn't intended. Feb 15, 2023
@epage epage merged commit 8c92ef6 into clap-rs:master Feb 15, 2023
@not-my-profile
Copy link
Contributor Author

Thanks!

not-my-profile added a commit to not-my-profile/ruff that referenced this pull request Feb 15, 2023
My two clap bug fixes[1][2] have been merged and released
(see the change in README.md).

[1]: clap-rs/clap#4710
[2]: clap-rs/clap#4712
charliermarsh pushed a commit to astral-sh/ruff that referenced this pull request Feb 15, 2023
My two clap bug fixes[1][2] have been merged and released
(see the change in README.md).

[1]: clap-rs/clap#4710
[2]: clap-rs/clap#4712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants