Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate windows wasm build issue #1270

Closed
stevepentland opened this issue May 5, 2018 · 0 comments · Fixed by #1271
Closed

Investigate windows wasm build issue #1270

stevepentland opened this issue May 5, 2018 · 0 comments · Fixed by #1271

Comments

@stevepentland
Copy link

As reported at Drops-of-Diamond/diamond_drops#59 there seems to have been a missed case when wasm support was introduced. This will need to be fixed up and seems to be pretty straightforward.

The original work was done in #1190 in response to #1132
stevepentland added a commit to stevepentland/clap-rs that referenced this issue May 6, 2018
@stevepentland
Include guards around os-specific string elements.
4620ab1 
This seems to be something missed some time ago as the original
annotation for this 'use' was only feature debug. However this
broke builds using that feature on Windows.

This change uses guards both for the feature and also wasm/windows
specific targets/environments.

closes clap-rs#1270 and is done in response to Drops-of-Diamond/diamond_drops#59
@stevepentland stevepentland mentioned this issue May 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include guards around os-specific string elements. stevepentland/clap-rs
1 participant
@stevepentland