-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include guards around os-specific string elements. #1271
Conversation
This seems to be something missed some time ago as the original annotation for this 'use' was only feature debug. However this broke builds using that feature on Windows. This change uses guards both for the feature and also wasm/windows specific targets/environments. closes clap-rs#1270 and is done in response to Drops-of-Diamond/diamond_drops#59
@stevepentland, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbknapp to be a potential reviewer. |
I cannot locally reproduce the 1.20.0 failure, but it seems to be coming out of the Edit: After looking at the travis build history, it appears this failure started happening about 3 days ago |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @ChosunOne
Reviewed 1 of 1 files at r1. Comments from Reviewable |
Obviously the build needs to pass for 1.20.0 before merging. |
Yeah, but as I mentioned in my previous comment, the failure seems to be unrelated to this particular change and looks to have started about 3 days prior to this PR. The first time it failed was during this run. |
OK yeah fair enough, all the errors are coming from unicode-normalization-0.1.6/src/tables.rs. |
Sorry all, I was out for a while with my day job. I'm taking a look at this and will merge shortly 😉 |
Thanks! Let me know when this is in a release so that I can update the version in cargo.toml. |
Include guards around os-specific string elements.
This seems to be something missed some time ago as the original annotation for this 'use' was only feature debug. However this broke builds using that feature on Windows for a while.
This change uses guards both for the feature and also wasm/windows specific targets/environments.
These guards are the same as are currently in use for Windows/wasm in parser.rs
closes #1270 and is done in response to Drops-of-Diamond/diamond_drops#59
fyi: @jamesray1
This change is